[NODE-1606] Upgrade build container to 24.04#5615
Conversation
|
Run URL: https://github.com/dfinity/ic/actions/runs/15740979994 New container image: |
Bownairo
force-pushed
the
eero/container-env
branch
3 times, most recently
from
b033a1a to
fd0ef9f
Compare
Bownairo
force-pushed
the
eero/build-container-upgrade
branch
from
45fbd08 to
6305728
Compare
|
Run URL: https://github.com/dfinity/ic/actions/runs/15766929546 New container image: |
1. We depend on the system `strip` when compiling or linking. Updating this binary in #5615 has an effect on outputs that was not seen in the build graph. This adds a dependency on the system `strip` binary to the `hermetic_cc` linker and compiler. 2. `podman export` behaves differently after #5615. This adds an additional layer of sanitizing so that builds before and after the upgrade are consistent.
Bownairo
force-pushed
the
eero/build-container-upgrade
branch
from
648fe5c to
ca31125
Compare
|
Run URL: https://github.com/dfinity/ic/actions/runs/15836166147 New container image: |
Bownairo
force-pushed
the
eero/build-container-upgrade
branch
from
ce5d659 to
906aa9a
Compare
…c0a819f54a6e2ef3ee15a45e232a49 Image tag: 844f7be0c2407e733aeda4a9bc4f098c067c537002992253ba466122e93fdd36
|
Run URL: https://github.com/dfinity/ic/actions/runs/15855414348 New container image: |
joeodfinity
left a comment
joeodfinity
left a comment
There was a problem hiding this comment.
for the testnet/ hierarchy changes, looks good (explicit direction of use of the ansible builtins instead of the possibly overloaded "foo:" usage, with one change of synchronize: to the builtin copy:).
|
Btw might be worth running with |
mbjorkqvist
left a comment
mbjorkqvist
left a comment
There was a problem hiding this comment.
FI change LGTM, thanks @Bownairo!
mbjorkqvist
left a comment
mbjorkqvist
left a comment
There was a problem hiding this comment.
I ran a manual smoke test for the updated dependencies for the Rosetta Python examples and it seems fine, thanks @Bownairo!
basvandijk
left a comment
basvandijk
left a comment
There was a problem hiding this comment.
Nice! Consider triggering Release Testing on your branch to be extra sure this doesn't break something.
…7c120080c0a819f54a6e2ef3ee15a45e232a49" This reverts commit 96bf02e.
|
Results of release testing: https://github.com/dfinity/ic/actions/runs/15910902848
|
…0d60975c22be26ac1ea7e72573523d Image tag: 844f7be0c2407e733aeda4a9bc4f098c067c537002992253ba466122e93fdd36
|
Run URL: https://github.com/dfinity/ic/actions/runs/15916605407 New container image: |
8 participants
Long ago, #1946 was pushed and reverted because it raised the minimum required libc version of our distributed binaries. With #4848, we should be able to upgrade again without this bump.