build: remove @ledgerhq/hw-transport-node-hid-noevents#7349
Draft
peterpeterparker wants to merge 1 commit intomainfrom
Draft
build: remove @ledgerhq/hw-transport-node-hid-noevents#7349peterpeterparker wants to merge 1 commit intomainfrom
peterpeterparker wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
2 tasks
Member
Author
|
@yhabib did a test and we had an issue with a peer dep, https://dfinity.enterprise.slack.com/archives/C08DN0K8Q9G/p1758009025184629 Not sure if it can be resolved, maybe it also has to do with vite polyfill? Need to check... or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When I looked at the removal of
bufferin #7348, I noticed that thepackage-lockwas not fully cleaned of references to it. After digging deeper, I found the reason: the usage of@ledgerhq/hw-transport-node-hid-noevents.Checking the repository, I learned that this library is meant to communicate with the Ledger on Node/Electron (HID).
It feels like this dependency is still referenced for historical reasons, perhaps from the time when the hardware wallet CLI was still part of the repo. I don’t think it’s necessary anymore.
Requires TESTs.
Changes
npm rm @ledgerhq/hw-transport-node-hid-noevents