Fix for concurrent requests on iOS with different fingerprints#65
Open
MaikelStuivenberg wants to merge 2 commits intodiefferson:masterfrom
Open
Fix for concurrent requests on iOS with different fingerprints#65MaikelStuivenberg wants to merge 2 commits intodiefferson:masterfrom
MaikelStuivenberg wants to merge 2 commits intodiefferson:masterfrom
Conversation
MaikelStuivenberg
changed the title
|
When will this PR be merged? |
Author
|
@Panz99 I guess never 🤷🏻♂️ |
Owner
|
Hey @MaikelStuivenberg Sorry for the super late answer, I notice that you only updated it on iOS code, this doesn't happen on Android? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing requests at the same time with different hostnames/fingerprints, the current version of the plugin will mix up the fingerprints as they are saved on class level. That results sometimes in unexpected certificate errors.
With this bugfix I changed the behaviour so that always the original fingerprint is used.