Skip to content

Fix for concurrent requests on iOS with different fingerprints #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaikelStuivenberg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for concurrent requests on iOS with different fingerprints #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0364c1
Pass fingerprints inside method instead of overwriting global variable
MaikelStuivenberg Mar 23, 2024
2f9b925
remove logging
MaikelStuivenberg Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions ios/Classes/SwiftHttpCertificatePinningPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import Alamofire
public class SwiftHttpCertificatePinningPlugin: NSObject, FlutterPlugin {

let manager = Alamofire.SessionManager.default
var fingerprints: Array<String>?
var flutterResult: FlutterResult?

public static func register(with registrar: FlutterPluginRegistrar) {
let channel = FlutterMethodChannel(name: "http_certificate_pinning", binaryMessenger: registrar.messenger())
Expand Down Expand Up @@ -41,7 +39,7 @@ public class SwiftHttpCertificatePinningPlugin: NSObject, FlutterPlugin {
){
guard let urlString = args["url"] as? String,
let headers = args["headers"] as? Dictionary<String, String>,
let fingerprints = args["fingerprints"] as? Array<String>,
let fingerprints = args["fingerprints"] as? Array<String>?,
let type = args["type"] as? String
else {
flutterResult(
Expand All @@ -53,9 +51,7 @@ public class SwiftHttpCertificatePinningPlugin: NSObject, FlutterPlugin {
)
return
}

self.fingerprints = fingerprints


var timeout = 60
if let timeoutArg = args["timeout"] as? Int {
timeout = timeoutArg
Expand Down Expand Up @@ -121,7 +117,7 @@ public class SwiftHttpCertificatePinningPlugin: NSObject, FlutterPlugin {
}

var isSecure = false
if var fp = self.fingerprints {
if var fp = fingerprints {
fp = fp.compactMap { (val) -> String? in
val.replacingOccurrences(of: " ", with: "")
}
Expand Down