feat(den): secure static worker attach#1894
Closed
pascalandr wants to merge 12 commits into
Closed
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@pascalandr is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
pascalandr
force-pushed
the
pr/static-worker-attach-security
branch
from
76ccc48 to
e1b5888
Compare
This was referenced May 22, 2026
Merge upstream dev into pr/static-worker-attach-security and resolve Den worker route conflicts while preserving static attach security checks and current dev billing behavior.
…ach-security # Conflicts: # apps/app/src/react-app/domains/settings/pages/cloud-workers-view.tsx
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Move static worker attach quota enforcement into the assignment lock so concurrent attach requests cannot exceed organization worker limits.
Permit explicitly allow-listed HTTPS worker hostnames while preserving DNS resolution checks against unsafe addresses.
Keep HTTPS static worker fetches on their certificate hostname and restrict Electron main-process fetches to configured remote workspace origins.
Contributor
Author
|
Superseded by the clean consolidated static/on-prem workers PR #2173. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds static worker attach security: attach route/UI, owner/admin permission gate, token verification without token echoing, SSRF/DNS-rebinding policy, and full static worker tests.
This PR is stacked on #1893. The branch was updated on top of the latest
pr/static-provisioner-backendcontent, and the attach-security tests live in this PR delta.Verification
bun test ee/apps/den-api/test/provisioner-static.test.ts— passed, 29 tests.pr/static-provisioner-backendreviewed; attach-security delta only:apps/app/src/react-app/domains/settings/pages/cloud-workers-view.tsxee/apps/den-api/src/routes/workers/core.tsee/apps/den-api/src/routes/workers/shared.tsee/apps/den-api/test/provisioner-static.test.tstasks/**,docs/scrs/**, codemaps, or generated app-version files are included.Known risks
dev, so the web diff includes feat(den): support static worker provisioner #1893 until feat(den): support static worker provisioner #1893 lands.pr/static-provisioner-backendwas attempted, but GitHub rejected it because that branch exists on the Pagecran fork for PR feat(den): support static worker provisioner #1893, not as a base branch indifferent-ai/openwork.Linked issues