Add more tests for CA2007 rule for await using and await foreach cases - #55542
Open
DoctorKrolic wants to merge 1 commit into
Open
Add more tests for CA2007 rule for await using and await foreach cases#55542DoctorKrolic wants to merge 1 commit into
CA2007 rule for await using and await foreach cases#55542DoctorKrolic wants to merge 1 commit into
Conversation
…` cases, fix some problems along the way
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #55036 (comment)
The way to check for
IAsyncEnumerableturned out to be incorrect since generics are involved, so had to fix that. Added a bunch more tests than asked in the initial feedback so now we have coverage even for such extreme cases like aref structimplementing anIAsyncDisposable/IAsyncEnumerable<T>CC @tannergooding I had a busy week so this is a bit later then I originally expected. Still kept the promise though)