Skip to content

Add more tests for CA2007 rule for await using and await foreach cases #55542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DoctorKrolic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add more tests for CA2007 rule for await using and await foreach cases #55542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...tAnalyzers/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/DoNotDirectlyAwaitATask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,13 @@ public override void Initialize(AnalysisContext context)

private static void AnalyzeAwaitForEachLoopOperation(OperationAnalysisContext context, INamedTypeSymbol iAsyncEnumerable, INamedTypeSymbol configuredAsyncEnumerable)
{
if (context.Operation is IForEachLoopOperation { IsAsynchronous: true, Collection.Type: not null } forEachOperation)
if (context.Operation is IForEachLoopOperation { IsAsynchronous: true, Collection.Type: { } collectionType } forEachOperation &&
!collectionType.IsRefLikeType &&
!collectionType.OriginalDefinition.Equals(configuredAsyncEnumerable, SymbolEqualityComparer.Default))
{
var collectionTypeOriginalDefinition = forEachOperation.Collection.Type.OriginalDefinition;

if (!collectionTypeOriginalDefinition.Equals(configuredAsyncEnumerable, SymbolEqualityComparer.Default) &&
context.Compilation.ClassifyCommonConversion(collectionTypeOriginalDefinition, iAsyncEnumerable) is { Exists: true, IsImplicit: true })
// Type is itself IAsyncEnumerable<T> or implements/extends IAsyncEnumerable<T>
if (collectionType.OriginalDefinition.Equals(iAsyncEnumerable, SymbolEqualityComparer.Default) ||
collectionType.AllInterfaces.Any(i => i.OriginalDefinition.Equals(iAsyncEnumerable, SymbolEqualityComparer.Default)))
{
context.ReportDiagnostic(forEachOperation.Collection.CreateDiagnostic(Rule));
}
Expand Down
Loading
Loading