Skip to content

refactor(rhi): sweep raw GL call sites out of OloEngine/src — Phase 2 step 2 (#691) - #700

Merged
drsnuggles8 merged 3 commits into
masterfrom
feature/vulkan-rhi-phase2-callsite-sweep-691
Jul 31, 2026
Merged

refactor(rhi): sweep raw GL call sites out of OloEngine/src — Phase 2 step 2 (#691)#700
drsnuggles8 merged 3 commits into
masterfrom
feature/vulkan-rhi-phase2-callsite-sweep-691

fix(rhi): do not silently cap RestoreAllFramebufferDrawAttachments at 16

2d22926
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 31, 2026 in 1h 11m 38s

Quality Gate passed

Issues
152 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 478 in OloEngine/src/OloEngine/Renderer/RenderCommand.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the function arguments to make its use less error-prone. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VB4CO3a6BsbwkBd&open=AZ-18VB4CO3a6BsbwkBd&pullRequest=700

Check warning on line 96 in OloEngine/src/OloEngine/Renderer/Occlusion/OcclusionQueryPool.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "available" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18U9BCO3a6BsbwkBa&open=AZ-18U9BCO3a6BsbwkBa&pullRequest=700

Check warning on line 610 in OloEngine/src/OloEngine/Renderer/VirtualGeometry/VirtualMeshRegistry.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "OloEngine::RHI::Filter". 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18U62CO3a6BsbwkBZ&open=AZ-18U62CO3a6BsbwkBZ&pullRequest=700

Check warning on line 1523 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the function arguments to make its use less error-prone. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkCx&open=AZ-18VM8CO3a6BsbwkCx&pullRequest=700

Check warning on line 1618 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkC-&open=AZ-18VM8CO3a6BsbwkC-&pullRequest=700

Check failure on line 647 in OloEngine/src/OloEngine/Renderer/RenderCommand.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VB4CO3a6BsbwkBv&open=AZ-18VB4CO3a6BsbwkBv&pullRequest=700

Check failure on line 374 in OloEngine/src/Platform/OpenGL/OpenGLRHIConversions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VN4CO3a6BsbwkDa&open=AZ-18VN4CO3a6BsbwkDa&pullRequest=700

Check warning on line 1714 in OloEngine/src/OloEngine/Renderer/Commands/CommandDispatch.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'sizet' (aka 'unsigned long long') to 'u32' (aka 'unsigned int') 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18UpACO3a6BsbwkBQ&open=AZ-18UpACO3a6BsbwkBQ&pullRequest=700

Check warning on line 1261 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the function arguments to make its use less error-prone. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkCU&open=AZ-18VM8CO3a6BsbwkCU&pullRequest=700

Check warning on line 587 in OloEngine/src/OloEngine/Renderer/RenderCommand.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the function arguments to make its use less error-prone. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VB4CO3a6BsbwkBj&open=AZ-18VB4CO3a6BsbwkBj&pullRequest=700

Check warning on line 128 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VOVCO3a6BsbwkDn&open=AZ-18VOVCO3a6BsbwkDn&pullRequest=700

Check warning on line 1807 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkDQ&open=AZ-18VM8CO3a6BsbwkDQ&pullRequest=700

Check warning on line 637 in OloEngine/src/OloEngine/Renderer/RenderCommand.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the function arguments to make its use less error-prone. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VB4CO3a6BsbwkBl&open=AZ-18VB4CO3a6BsbwkBl&pullRequest=700

Check warning on line 1417 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkCj&open=AZ-18VM8CO3a6BsbwkCj&pullRequest=700

Check failure on line 656 in OloEngine/src/OloEngine/Renderer/RenderCommand.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VB4CO3a6BsbwkBw&open=AZ-18VB4CO3a6BsbwkBw&pullRequest=700

Check warning on line 1738 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkDL&open=AZ-18VM8CO3a6BsbwkDL&pullRequest=700

Check warning on line 1657 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkDC&open=AZ-18VM8CO3a6BsbwkDC&pullRequest=700

Check warning on line 1689 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkDF&open=AZ-18VM8CO3a6BsbwkDF&pullRequest=700

Check warning on line 1151 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkCG&open=AZ-18VM8CO3a6BsbwkCG&pullRequest=700

Check warning on line 1408 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkCi&open=AZ-18VM8CO3a6BsbwkCi&pullRequest=700

Check warning on line 1585 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkC6&open=AZ-18VM8CO3a6BsbwkC6&pullRequest=700

Check warning on line 1154 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkCH&open=AZ-18VM8CO3a6BsbwkCH&pullRequest=700

Check warning on line 1595 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the function arguments to make its use less error-prone. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkC7&open=AZ-18VM8CO3a6BsbwkC7&pullRequest=700

Check warning on line 1119 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkCD&open=AZ-18VM8CO3a6BsbwkCD&pullRequest=700

Check warning on line 1609 in OloEngine/src/Platform/OpenGL/OpenGLRendererAPI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ-18VM8CO3a6BsbwkC9&open=AZ-18VM8CO3a6BsbwkC9&pullRequest=700
View more details on SonarQubeCloud