Conversation
|
This work is so appreciated! Thank you @j23n. I fully support the move to Actions and trusted publishing. You are welcome to fully drop Python 3.9 support as it is now end of life (this project isn't something I've kept updated, clearly). It might take me just a little bit to get to this to check publishing and so on, but I'd very much like to accept this PR. |
|
thanks for your fast response! I kept 3.9 in there because django 4.2 is not yet EoL and supports Python 3.9 (and 3.8 actually). Happy to drop 3.9 though, just let me know. No worries, this isn't urgent. For completeness, here's the trusted publisher docs :-) |
Fair point, will think on that for a bit.
I've started using trusted publishing in a few other projects and like it quite a bit, so hopefully just a matter of a little bit of config 😄 |
daneah
left a comment
There was a problem hiding this comment.
Let's keep Python 3.9 support as part of this change, which is internal, and remove that support in a separate changeset where we'll also bump to a major version. Although currently-supported Django versions may support an EOL'd version of Python, it doesn't mean we should be enablers in that regard!
There is one thing to fix up in the Actions config regarding building the package.
.github/workflows/ci.yaml
Outdated
| with: | ||
| python-version: "3.14" | ||
| - name: Build package | ||
| run: python setup.py sdist bdist_wheel |
There was a problem hiding this comment.
This (and corresponding in publish-pypi-test) should now be using pyproject-build.
pyproject.toml
Outdated
| @@ -45,7 +45,7 @@ line-length = 120 | |||
| target-version = ["py39", "py310", "py311", "py312", "py313"] | |||
There was a problem hiding this comment.
| target-version = ["py39", "py310", "py311", "py312", "py313"] | |
| target-version = ["py39", "py310", "py311", "py312", "py313", "py314"] |
e058e76 to
3ac69d6
Compare
3ac69d6 to
97f7eac
Compare
|
@daneah sorry, this got a bit messy. I'll rebase and open a new PR with your review. |
Hello, this is a proposal to switch to Github actions (#26). You can see the output on my fork: https://github.com/j23n/django-webmention/actions/runs/22139411981
A couple of notes:
pyproject.tomlmatchinternally, which is not supported by Python 3.9Let me know if I missed anything :-)