Refactor to reuse Podman client for HTTP requests in runtime#523
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Podman runtime HTTP helper layer in nodeagent to reuse a single hyper::Client instance across requests, reducing per-call client construction overhead and centralizing the Podman socket path.
Changes:
- Introduced a shared, lazily-initialized
PODMAN_CLIENT(once_cell::sync::Lazy) for all Podman HTTP requests. - Centralized the Podman Unix socket path into a single
PODMAN_SOCKETconstant. - Updated
get/post/deletehelpers to use the shared client and socket constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the HTTP client usage in the Podman runtime module to improve efficiency and code clarity. The main change is that the code now uses a single, shared
hyper::Clientinstance for all requests, instead of creating a new client on each call. This reduces resource usage and improves performance.Podman HTTP client refactor:
PODMAN_CLIENTusingonce_cell::sync::Lazy, so thehyper::Clientis created only once and reused for allget,post, anddeleterequests.PODMAN_SOCKET, removing repeated code and making it easier to update the socket path if needed.get,post, anddeletefunctions to use the shared client and socket constant, reducing duplication and potential for errors.