Skip to content

Refactor to reuse Podman client for HTTP requests in runtime #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youngtaekiim merged 1 commit into from
Jul 9, 2026
Merged

Refactor to reuse Podman client for HTTP requests in runtime #523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 22 additions & 34 deletions src/agent/nodeagent/src/runtime/podman/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,64 +8,52 @@ pub mod container;
use common::nodeagent::fromactioncontroller::WorkloadCommand;
use hyper::{Body, Client, Method, Request, Uri};
use hyperlocal::{UnixConnector, Uri as UnixUri};
use once_cell::sync::Lazy;

// Modify this if you want to run without root authorization
// or if you have a different socket path.
// For example, if you run Podman as root, you might use:
// "/var/run/podman/podman.sock"
// Or if you run it as a user, you might use:
// "/run/user/1000/podman/podman.sock"
const PODMAN_SOCKET: &str = "/var/run/podman/podman.sock";

// A single `hyper::Client` is cheap to clone and manages its own connection
// pool internally, so it is created once and reused for every request
// instead of being rebuilt on each call to `get`/`post`/`delete`.
static PODMAN_CLIENT: Lazy<Client<UnixConnector, Body>> =
Lazy::new(|| Client::builder().build::<_, Body>(UnixConnector));

pub async fn get(path: &str) -> Result<hyper::body::Bytes, hyper::Error> {
let connector = UnixConnector;
let client = Client::builder().build::<_, Body>(connector);

// Modify this if you want to run without root authorization
// or if you have a different socket path.
// For example, if you run Podman as root, you might use:
// let socket = "/var/run/podman/podman.sock";
// Or if you run it as a user, you might use:
// let socket = "/run/user/1000/podman/podman.sock
let socket = "/var/run/podman/podman.sock";
// let socket = "/var/run/podman/podman.sock";
let uri: Uri = UnixUri::new(socket, path).into();

let res = client.get(uri).await?;
let uri: Uri = UnixUri::new(PODMAN_SOCKET, path).into();

let res = PODMAN_CLIENT.get(uri).await?;
hyper::body::to_bytes(res).await
}

pub async fn post(path: &str, body: Body) -> Result<hyper::body::Bytes, hyper::Error> {
let connector = UnixConnector;
let client = Client::builder().build::<_, Body>(connector);

// Modify this if you want to run without root authorization
// or if you have a different socket path.
// For example, if you run Podman as root, you might use:
// let socket = "/var/run/podman/podman.sock";
// Or if you run it as a user, you might use:
// let socket = "/run/user/1000/podman/podman.sock
let socket = "/var/run/podman/podman.sock";
// let socket = "/var/run/podman/podman.sock";
// let path = "/v4.0.0/libpod/containers/{name}/start";
let uri: Uri = UnixUri::new(socket, path).into();
let uri: Uri = UnixUri::new(PODMAN_SOCKET, path).into();

let req = Request::builder()
.method(Method::POST)
.uri(uri)
.body(body)
.unwrap();
Comment thread
youngtaekiim marked this conversation as resolved.

let res = client.request(req).await?;
let res = PODMAN_CLIENT.request(req).await?;
hyper::body::to_bytes(res).await
}

pub async fn delete(path: &str) -> Result<hyper::body::Bytes, hyper::Error> {
let connector = UnixConnector;
let client = Client::builder().build::<_, Body>(connector);

let socket = "/var/run/podman/podman.sock";
let uri: Uri = UnixUri::new(socket, path).into();
let uri: Uri = UnixUri::new(PODMAN_SOCKET, path).into();

let req = Request::builder()
.method(Method::DELETE)
.uri(uri)
.body(Body::empty())
.unwrap();
Comment thread
youngtaekiim marked this conversation as resolved.

let res = client.request(req).await?;
let res = PODMAN_CLIENT.request(req).await?;
hyper::body::to_bytes(res).await
}

Expand Down