Skip to content

Conversation

@pendula95
Copy link
Contributor

No description provided.

@pendula95
Copy link
Contributor Author

@vietj all the tests on local run are passing, this is ready for review

@pendula95 pendula95 marked this pull request as ready for review January 10, 2026 22:04
@vietj
Copy link
Member

vietj commented Jan 11, 2026

@pendula95 can you make a rebase of this PR on latest master please ?

@vietj
Copy link
Member

vietj commented Jan 11, 2026

@pendula95 can you also look at other projects in the vertx stack that are using this project (e.g. I think vertx-service-resolver uses it) and check that those projects can use the new mock dns server ?

@pendula95
Copy link
Contributor Author

@pendula95 can you also look at other projects in the vertx stack that are using this project (e.g. I think vertx-service-resolver uses it) and check that those projects can use the new mock dns server ?

I have checked both eclipse-vertx and vert-x3 organizations for code references of apacheds-protocol-dns an I only found reference in vertx-service-resolver and https://github.com/vert-x3/vertx-stack

vertx-service-resolver has been addressed and PR submitted eclipse-vertx/vertx-service-resolver#31

For vertx-stack I guess the property also could be removed.

Resolves #5819

@vietj
Copy link
Member

vietj commented Jan 12, 2026

@pendula95 great work, can you provide a single commit for this PR based on the latest master ?

@pendula95
Copy link
Contributor Author

@pendula95 great work, can you provide a single commit for this PR based on the latest master ?

I am unable to elegantly squash it using git rebase -i origin/master. Is it possible to squash and merge via merge?

@vietj
Copy link
Member

vietj commented Jan 13, 2026

@pendula95 I think you can create a new branch from latest master and cherry pick commits of your branch on top of it

# Conflicts:
#	vertx-core/src/test/java/io/vertx/tests/http/HttpTest.java
@pendula95
Copy link
Contributor Author

@pendula95 I think you can create a new branch from latest master and cherry pick commits of your branch on top of it

#5900

@pendula95
Copy link
Contributor Author

Resolved by #5900

@pendula95 pendula95 closed this Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants