Skip to content

fix(frontend): tighten logo sizing and spacing on login and home#319

Merged
hamza-56 merged 1 commit into
mainfrom
feat/login-style-refresh
May 13, 2026
Merged

fix(frontend): tighten logo sizing and spacing on login and home#319
hamza-56 merged 1 commit into
mainfrom
feat/login-style-refresh

Conversation

@hamza-56
Copy link
Copy Markdown
Contributor

What

The Sparkth logo (which includes the "compose" wordmark + "powered by Edly" subtitle scaled relative to size) was rendering oversized and crowding adjacent text on both the login page and the index page.

Changes

  • Login (`app/login/LoginForm.tsx`): logo `size` 72 → 56, wrapper margin `mb-1` → `mb-6` so the wordmark no longer bleeds into the "Log in" heading.
  • Home (`app/page-client.tsx`): logo `size` 120 → 72 (was producing a ~74px wordmark that overwhelmed the hero), wrapper margin `mb-8` → `mb-4`.

Test plan

  • Visit `/login` — logo sits comfortably above "Log in" with breathing room.
  • Visit `/` (unauthenticated) — logo proportionate to the "Welcome to Sparkth" heading.
  • Verify in both light and dark themes.

@claude
Copy link
Copy Markdown

claude Bot commented May 12, 2026

Claude finished @hamza-56's task in 1m 21s —— View job


Review: PR #319 — Logo sizing and spacing fixes

  • Gather context and check previous review comments
  • Review changed files and diff
  • Check for React anti-patterns
  • Post review summary

Looks good overall. This is a low-risk, styling-only change — no functional logic, no React anti-patterns, and the prop/class tweaks are straightforward.

Changes reviewed

File What changed
LoginForm.tsx Logo size 72 → 56, margin mb-1mb-6
page-client.tsx Logo size 120 → 72, margin mb-8mb-4

Notes

  • No blocking issues.
  • The SparkthLogo component scales all sub-elements (icon, wordmark, subtitle) proportionally from the size prop, so the changes are self-contained and won't break layout elsewhere.
  • Home page hero logo (72) is now smaller than the SparkthHeader logo (80, used on the same page). This is likely fine for visual hierarchy — the header anchors the brand while the hero directs attention to the heading — but worth a quick visual check.

Suggestion

The register page (frontend/app/register/RegisterForm.tsx:73) still uses mb-1 with size={72} — the same crowded pattern this PR fixes on login. Consider applying mb-6 there too for consistency (left an inline comment).

Previous review comments

No prior review comments on this PR.

@hamza-56 hamza-56 self-assigned this May 12, 2026
</div>
<div className="flex justify-center mb-1">
<SparkthLogo size={72} />
<div className="flex justify-center mb-6">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (low): The register page (frontend/app/register/RegisterForm.tsx:73) still uses mb-1 with size={72} — the exact same pattern that was crowding the login page before this fix. Worth applying the same mb-6 treatment there for consistency.

Fix this →

Copy link
Copy Markdown
Contributor

@abdulrafey1 abdulrafey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamza-56 hamza-56 merged commit e9af3c9 into main May 13, 2026
7 checks passed
@hamza-56 hamza-56 deleted the feat/login-style-refresh branch May 13, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants