fix(frontend): tighten logo sizing and spacing on login and home#319
Merged
Conversation
|
Claude finished @hamza-56's task in 1m 21s —— View job Review: PR #319 — Logo sizing and spacing fixes
Looks good overall. This is a low-risk, styling-only change — no functional logic, no React anti-patterns, and the prop/class tweaks are straightforward. Changes reviewed
Notes
SuggestionThe register page ( Previous review commentsNo prior review comments on this PR. |
| </div> | ||
| <div className="flex justify-center mb-1"> | ||
| <SparkthLogo size={72} /> | ||
| <div className="flex justify-center mb-6"> |
There was a problem hiding this comment.
Nit (low): The register page (frontend/app/register/RegisterForm.tsx:73) still uses mb-1 with size={72} — the exact same pattern that was crowding the login page before this fix. Worth applying the same mb-6 treatment there for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Sparkth logo (which includes the "compose" wordmark + "powered by Edly" subtitle scaled relative to size) was rendering oversized and crowding adjacent text on both the login page and the index page.
Changes
Test plan