fix: correct variables definition #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
approved these changes
Dec 6, 2025
Contributor
|
Disk space failures should be less often after a fix in master now. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect YAML syntax in GitLab CI variable definitions for benchmark jobs. The original code attempted to define variables as a list with !reference tags, which is invalid syntax for the variables section in GitLab CI. The fix correctly changes the definitions to simple key-value pairs.
Key Changes
- Fixed
.benchmarks:defaulttemplate by changingBUILD_TYPEfrom list format to proper key-value format - Fixed
.benchmarks:nightlytemplate with the same correction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix that was applied to v25.12.0-stable to make it build. Specifically this prevents nightly benchmarks from being enabled and be failing due to missing nightly container jobs.