car_diff: dedupe errors and render them in a dropdown#480
Closed
elkoled wants to merge 1 commit into
Closed
Conversation
A single failing carcontroller raises the same traceback for every segment, printing dozens of identical tracebacks at the top of the report. Group errors by their text, print each unique one once with the affected segment count, and wrap the block in a details dropdown like the diff section so it does not spam the PR comment. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Car behavior reportReplays driving segments through this PR and compares the behavior to master. ✅ No changes detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
car_diff.pycatches per-segment replay exceptions, but the report then prints one full traceback per failing segment. A single buggy carcontroller produced ~40 identical tracebacks at the top of the PR comment.Fix
Group errors by their text, print each unique one once tagged
(Nx)with the affected segment count, and wrap the block in a collapsible<details>dropdown like the existing diff section.Validated earlier against a deliberately-broken nissan replay: 40 identical tracebacks collapsed to a single dropdown block.
🤖 Generated with Claude Code