Skip to content

car_diff: dedupe errors and render them in a dropdown #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elkoled wants to merge 1 commit into from
Closed

car_diff: dedupe errors and render them in a dropdown #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions opendbc/car/tests/car_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,16 @@ def main(platform: str | None = None, segments_per_platform: int = 10, update_re
icon = "⚠️" if with_diffs else "✅"
print(f"\n{icon} {len(with_diffs)} changed, {n_passed} passed, {len(errors)} errors")

for plat, seg, err in errors:
print(f"\nERROR {plat} - {seg}: {err}")
if errors:
# Group identical errors so a single bug doesn't spam the report with one traceback per segment
by_err: dict[str, list[str]] = defaultdict(list)
for plat, seg, err in errors:
by_err[err].append(f"{plat} - {seg}")
print("<details><summary><b>Show errors</b></summary>\n\n```")
for err, segs in sorted(by_err.items(), key=lambda kv: -len(kv[1])):
affected = ", ".join(segs[:3]) + (f" (+{len(segs) - 3} more)" if len(segs) > 3 else "")
print(f"\nERROR ({len(segs)}x) {affected}:\n{err.rstrip()}")
print("```\n</details>")

if with_diffs:
print("<details><summary><b>Show changes</b></summary>\n\n```")
Expand Down
Loading