Document legacy action modifier interaction with component event handlers#21408
Open
olenderhub wants to merge 1 commit into
Open
Document legacy action modifier interaction with component event handlers#21408olenderhub wants to merge 1 commit into
olenderhub wants to merge 1 commit into
Conversation
| > current Ember. See the | ||
| > [template-action deprecation guide](https://deprecations.emberjs.com/id/template-action/) | ||
| > for migration details. Use the `{{on}}` modifier instead. | ||
|
|
Contributor
There was a problem hiding this comment.
since {{action}} is no longer available, is this comment still relevant? is there code we can cleanup around this behavior instead?
Contributor
Author
There was a problem hiding this comment.
@NullVoxPopuli I see what you mean. I picked this up because #17877 and #17877 (comment) seemed to ask for documentation around this legacy interaction.
Given that {{action}} is no longer available in current Ember, does it make sense to close #17877? If so, I can close this PR too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a legacy note to the
@ember/componentAPI docs under the "Event Handler Methods" section.Issue #17877 asked about documenting ordering semantics between classic component event handler methods, legacy
{{action}}, and actions forwarded through...attributes. Since{{action}}is no longer available in current Ember, this note avoids documenting it as current API and instead points readers to{{on}}.The note links to the template-action deprecation guide for migration details.
I intentionally avoided stating a specific same-element ordering because I could not find an existing test covering classic component event handlers and
{{action}}on the same element. The note only calls out that this combination relied on legacy event dispatching and had subtle ordering semantics.Refs #17877