Skip to content

Document legacy action modifier interaction with component event handlers #21408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olenderhub wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Document legacy action modifier interaction with component event handlers #21408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/@ember/-internals/glimmer/lib/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,18 @@ declare const SIGNATURE: unique symbol;
* `dragEnd`
* `drop`

> **Note on legacy `{{action}}` usage:** In Ember versions where the legacy
> `{{action}}` modifier was available, classic component event handler methods
> could be combined with `{{action}}`, including action modifiers forwarded
> through `...attributes`. This combination relied on Ember's legacy event
> dispatching system and had subtle ordering semantics, particularly when
> handlers were placed on the same element versus nested elements.
>
> The `{{action}}` modifier was deprecated and is no longer available in
> current Ember. See the
> [template-action deprecation guide](https://deprecations.emberjs.com/id/template-action/)
> for migration details. Use the `{{on}}` modifier instead.

Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since {{action}} is no longer available, is this comment still relevant? is there code we can cleanup around this behavior instead?

Copy link
Copy Markdown
Contributor Author

@olenderhub olenderhub May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli I see what you mean. I picked this up because #17877 and #17877 (comment) seemed to ask for documentation around this legacy interaction.

Given that {{action}} is no longer available in current Ember, does it make sense to close #17877? If so, I can close this PR too.

@class Component
@extends Ember.CoreView
@uses Ember.TargetActionSupport
Expand Down
Loading