fix: move valid_solved_count increment past same-account guard#387
Open
Grizouforever wants to merge 1 commit intoentrius:testfrom
Open
fix: move valid_solved_count increment past same-account guard#387Grizouforever wants to merge 1 commit intoentrius:testfrom
Grizouforever wants to merge 1 commit intoentrius:testfrom
Conversation
Self-solved issues were being counted toward valid_solved_count before the discoverer == solver guard, allowing a miner to unlock the issue discovery reward pool without legitimately discovering bugs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the
data.valid_solved_count += 1increment to after the same-account guard in_collect_issues_from_prs. Previously, self-solved issues (where discoverer == solver) were counted towardvalid_solved_countbefore the guard could skip them, allowing a miner to falsely satisfy the eligibility gate for the issue discovery reward pool.@anderdc @LandynDev
Related Issues
Fixes #386
Type of Change
Testing
All 272 existing tests pass (
pytest tests/ -x -q).Checklist