Skip to content

fix: move valid_solved_count increment past same-account guard #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Grizouforever wants to merge 1 commit into from
+6 −4
Closed

fix: move valid_solved_count increment past same-account guard #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions gittensor/validator/issue_discovery/scoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,14 +245,16 @@ def _collect_issues_from_prs(
data.closed_count += 1
continue

# Count valid solved (PR quality gate only — independent of same-account/one-per-PR)
if pr.token_score >= MIN_TOKEN_SCORE_FOR_BASE_SCORE:
data.valid_solved_count += 1

# Same-account: discoverer == solver → 0 score but credibility counts
if discoverer_id == pr.github_id:
continue

# Count valid solved (PR quality gate only — independent of same-account/one-per-PR)
# NOTE: must be after same-account guard so self-solved issues don't
# falsely count toward the eligibility threshold for the reward pool.
if pr.token_score >= MIN_TOKEN_SCORE_FOR_BASE_SCORE:
data.valid_solved_count += 1

# One-issue-per-PR: only the first (earliest-created) issue gets scored
pr_key = (pr.repository_full_name, pr.number)
if pr_key in pr_scored:
Expand Down