Skip to content

Fix NoSuchElementException if package is not exported#193

Merged
nedtwigg merged 2 commits into
equodev:mainfrom
jochenberger:patch-1
May 28, 2026
Merged

Fix NoSuchElementException if package is not exported#193
nedtwigg merged 2 commits into
equodev:mainfrom
jochenberger:patch-1

Conversation

@jochenberger
Copy link
Copy Markdown
Contributor

I'm not very confident that this is the correct fix. I want to address diffplug/spotless#2926 and TBH, I'm just trying to coax a reaction out of you. 😉

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 27, 2026

CLA assistant check
All committers have signed the CLA.

@nedtwigg
Copy link
Copy Markdown
Collaborator

This looks reasonable to me. If you sign the CLA, spotlessApply, and update the changelog, I'll press merge and then press the release button.

@nedtwigg
Copy link
Copy Markdown
Collaborator

If you wanted a better test environment for the Groovy case you care about, I would look at https://github.com/equodev/equo-ide/blob/main/P2_MULTITOOL.md

@jochenberger
Copy link
Copy Markdown
Contributor Author

Thanks for the heads-up. Great plug-in btw. 👍
I tried to set up an Eclipse with Groovy-Eclipse like spotless does (https://github.com/jochenberger/greclipse-debug/blob/main/build.gradle), but running it fails with

...
java.lang.RuntimeException: java.io.FileNotFoundException: JAR entry META-INF/MANIFEST.MF not found in /home/jochen/ide-workspaces/greclipse-debug-2082510762/nested-jars/org.codehaus.groovy_5.0.0.v202503311943-e2503.jar__groovy-parser2.jar__eV7mFjZ8paqoj0hcbKMr3Q--.jar
        at dev.equo.solstice.Unchecked.wrap(Unchecked.java:47)
        at dev.equo.solstice.SolsticeManifest.<init>(SolsticeManifest.java:97)
        at dev.equo.solstice.SolsticeManifest.parseJar(SolsticeManifest.java:54)
        at dev.equo.ide.BuildPluginIdeMain$Caller.launch(BuildPluginIdeMain.java:147)
        at dev.equo.ide.gradle.EquoIdeTask.launch(EquoIdeTask.java:157)
...

@jochenberger
Copy link
Copy Markdown
Contributor Author

The tests seem to fail on main too.

@nedtwigg
Copy link
Copy Markdown
Collaborator

Probably one of the p2 sites that this tests against has gone dead. The clean thing to do would be to open a new PR that gets main passing successfully, and then merge main into this. If you want to sloppily combine that into this PR, I think that would be okay too.

There is some risk that the deployment secrets (Sonatype password, etc) have expired or been rotated. It's been more than a year since the last publish. If the deploy pipeline has gone stale, I can't bring it back to life, only someone still at Equo can do that, and I'm not sure how important this project is for them on their current roadmap.

Happy to merge PRs and press the release button on your behalf @jochenberger, but just want to be up front about the risk factors 👍

@jochenberger
Copy link
Copy Markdown
Contributor Author

Well, then, I'm crossing fingers.

@jochenberger
Copy link
Copy Markdown
Contributor Author

#194 should fix the test.

@nedtwigg nedtwigg merged commit aa462f9 into equodev:main May 28, 2026
4 checks passed
@nedtwigg
Copy link
Copy Markdown
Collaborator

As I feared, Sonatype forced all projects to jump through a big migration hoop in June 2025, and this project hasn't jumped through it yet. Details at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants