Skip to content

Fix NoSuchElementException if package is not exported #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nedtwigg merged 2 commits into from
May 28, 2026
Merged

Fix NoSuchElementException if package is not exported #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e16b40
Fix NoSuchElementException if package is not exported
May 27, 2026
bc31cbb
Merge branch 'main' into patch-1
nedtwigg May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions solstice/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ We adhere to the [keepachangelog](https://keepachangelog.com/en/1.0.0/) format.

## [Unreleased]
### Fixed
- Fix NoSuchElementException if package is not exported
- Update selfie snapshot to fix P2Test

## [1.8.1] - 2025-01-14
Expand Down
14 changes: 8 additions & 6 deletions solstice/src/main/java/dev/equo/solstice/Solstice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2023 EquoTech, Inc. and others.
* Copyright (c) 2023-2026 EquoTech, Inc. and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -293,11 +293,13 @@ private boolean pkgExportIsNotDuplicate(
if (thisManifest.totalPkgImports().contains(pkg)) {
return true;
}
var element =
thisManifest.pkgExportsRaw().stream()
.filter(e -> e.getValue().equals(pkg))
.findFirst()
.get();
var elementOpt =
thisManifest.pkgExportsRaw().stream().filter(e -> e.getValue().equals(pkg)).findFirst();
if (elementOpt.isEmpty()) {
return false;
}
var element = elementOpt.get();

String mandatory = element.getDirective("mandatory");
if (mandatory != null) {
if ("split".equals(element.getAttribute(mandatory))) {
Expand Down
Loading