This repository was archived by the owner on Jun 11, 2019. It is now read-only.
Open
Conversation
Commit 286125b fixed an error from where badly encoded data would cause crashes, but the fix of piping it through iconv mean that the status code returned was that of iconv. This causes the module to always treat the pear module as "installed," meaning the install exec would never run. This changes fixes that by sending the standard output to /dev/null, which preserves the original exit code.
Author
|
herp, looks like I need to update the test |
Author
|
The spec program fails to load module puppet/face on the Puppet 2.6.0 build. As far as I can tell that module only works with 2.7.0 or newer, and it looks like this is also failing on master. |
Member
|
For me is ok, maybe @feychenie maybe give his opinion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 286125b fixed an error from where badly encoded data would cause crashes,
but the fix of piping it through iconv mean that the status code returned was
that of iconv. This causes the module to always treat the pear module as
"installed," meaning the install exec would never run. This changes fixes that
by sending the standard output to /dev/null, which preserves the original exit
code.