Skip to content

Conversation

@KarasTomas
Copy link
Collaborator

Implementation of strain funkcionality based on the Issue #33.

There are still some topics that needs to be discussed:

  • Work with true or engineering strain
  • Implement calculations for simple strain cases (uniaxial, no shear) for faster compute time
  • version of Von Mises (component or principal strain based)
  • What other methods of signing to implement

@KarasTomas KarasTomas added the WIP Work In Progress label Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@Vybornak2 Vybornak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in stress version stress_vector_voigt is used while in strain strain_voigt. This should be unified. I suggest vector version.

test for test_calc_signed_von_mises_by_max_abs_principal utilize second invariant of deviatoric stress as tests for stress version do, but I am not sure about this formula for strain variants. Please check this (potentially mistake could be in stress version too)

Copy link
Collaborator Author

@KarasTomas KarasTomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the requested changes. There are still few comments that need discussion.



# Von Mises functions
def calc_von_mises_strain_from_principals(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to a branch sm_strain_dev in my fork. The test as well.

@Vybornak2
Copy link
Collaborator

@KarasTomas
I suggest following:

  1. create discussion whether to include planar stress / strain calculations, principal versions etc.
  2. based on WG6-Crosscollaboratioin Excel or in collaboration with @JanHPapuga find proper contacts to review strain functions, true vs engineering strain

Addressing issues - Quote:

Implementation of strain funkcionality based on the Issue #33.

There are still some topics that needs to be discussed:

  • Work with true or engineering strain
  • Implement calculations for simple strain cases (uniaxial, no shear) for faster compute time
  • version of Von Mises (component or principal strain based)
  • What other methods of signing to implement

@Vybornak2
Copy link
Collaborator

@KarasTomas review is required as I pushed last change - merge, please review it (just a formality), so we can close this PR.

Copy link
Collaborator Author

@KarasTomas KarasTomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is ready for merge.

@Vybornak2 Vybornak2 merged commit 4039731 into faberorg:main Nov 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work In Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants