Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Fishjam React Native example app configuration so it no longer uses Fishjam-owned application identifiers by default, and documents what identifiers users must customize before building on their own devices.
Changes:
- Replaced Fishjam-specific iOS bundle identifiers and Android package name with
com.example.*placeholders inapp.json. - Updated the iOS ScreenBroadcastExtension bundle identifier and app group entitlement to match the new placeholder namespace.
- Added a README note instructing users which
app.jsonfields must be updated before runningexpo prebuild.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/mobile-client/fishjam-chat/app.json | Switches iOS/Android identifiers and iOS extension/app-group IDs to non-Fishjam placeholders. |
| examples/mobile-client/fishjam-chat/README.md | Adds build guidance to update identifiers prior to prebuilding native projects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "ios": { | ||
| "supportsTablet": true, | ||
| "bundleIdentifier": "io.fishjam.example.fishjamchat", | ||
| "bundleIdentifier": "com.example.fishjamchat", |
There was a problem hiding this comment.
If the goal is to make the example buildable by people outside the fishjam-cloud Expo org (especially via eas build), the app is still tied to a specific Expo project via expo.owner and expo.extra.eas.projectId (and eas.json submit metadata). Consider removing these from the example config or documenting that users need to run eas init / update them to their own project before using EAS.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MiloszFilimowski
left a comment
MiloszFilimowski
left a comment
There was a problem hiding this comment.
Overall looks good, I'd just remove the groups and bundle identifiers from the app.json, so that the user will be forced to provide something.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removed outdated information regarding ScreenBroadcastExtension bundle identifier and App group entitlement.
Description
Made changes to describe how to build the example app
Motivation and Context
bundleIdentifier on iOS was tied to fishjam and wouldn't build on real device for people outside of fishjam org
Documentation impact
Types of changes
not work as expected)