Skip to content

Make iOS bundle id agnostic #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Magmusacy merged 6 commits into from
Mar 4, 2026
Merged

Make iOS bundle id agnostic #486

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d8cf7cf
Make iOS bundle id agnostic
Magmusacy Mar 3, 2026
a7caae3
Update examples/mobile-client/fishjam-chat/README.md
Magmusacy Mar 3, 2026
5b80ffa
Revert bundleIdentifier to initial state and add note in README how t…
Magmusacy Mar 4, 2026
972d069
Merge remote-tracking branch 'origin/FCE-2880' into FCE-2880
Magmusacy Mar 4, 2026
af902ad
Update README.md to remove obsolete bundle identifier info
MiloszFilimowski Mar 4, 2026
1676dd7
Merge branch 'main' into FCE-2880
Magmusacy Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions examples/mobile-client/fishjam-chat/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,18 @@ yarn
yarn build
```

> [!IMPORTANT]
> Before prebuilding, replace all occurrences of `io.fishjam.example.fishjamchat` in `app.json` with your own bundle identifier:
>
> - **iOS bundle identifier** — `expo.ios.bundleIdentifier`
> - **Android package name** — `expo.android.package`
>
> For example, if your bundle ID is `com.yourcompany.yourapp`:
>
> - iOS & Android: `com.yourcompany.yourapp`
> - ScreenBroadcastExtension: `com.yourcompany.yourapp.ScreenBroadcastExtension`
> - App group: `group.com.yourcompany.yourapp`

3. Prebuild native files in example directory:

```sh
Expand All @@ -56,10 +68,13 @@ yarn android
## Development

1. Whenever you make changes in the `packages` directory, make sure to build the app in the root directory (not in `examples/mobile-client/fishjam-chat`). This ensures that all related workspaces are also built:

```sh
yarn build
```

2. Linter (run in the root directory):

```sh
yarn lint
```
Loading