176983 Draft unified check-runs UI #4944
Conversation
…unctionality and UI consistency
- Deleted index.md, metadata.json, plan.md, spec.md, and screen.png files for the pr_dashboard_20260209 track. - Updated presubmit_view_20260209 code.html to improve formatting and structure. - Removed stitch_pr_test_dashboard_view.zip file.
There was a problem hiding this comment.
If you are done with the tracks, you might want to archive them so they show up in conductor/archive/ - the thing to keep around in the long term is the code.html that you used in case we want to build more styling similar to it.
There was a problem hiding this comment.
on my personal projects with monorepos, I've kept only one root conductor folder and made sure to call out the front end tech stack and backend tech stacks in the same file. I'm not sure if conductor / gemini will get confused with two different folders, but we'll see.
I'm assuming you just open gemini in the dashboard/ folder?
There was a problem hiding this comment.
right, I'm using dashboard/ folder to work with dashboard. but I can move extended description of dashboard to the root folder. Just experimented.
| sha = params['sha']; | ||
| pr = params['pr']; | ||
|
|
||
| if (pr == '123' || (sha != null && sha!.startsWith('mock_sha_'))) { |
There was a problem hiding this comment.
Do we load mock data in production views anywhere else? This should probably be with other fake data for the dashboard (in service/dev_cocoon.dart).
| final isDark = theme.brightness == Brightness.dark; | ||
| final buildState = Provider.of<BuildState>(context); | ||
|
|
||
| final availableShas = pr != null |
There was a problem hiding this comment.
dito on moving these to service/dev_cocoon.dart
| collection: any # Match Flutter SDK | ||
| firebase_auth: ^6.0.0 | ||
| firebase_core: 4.4.0 # Rolled by dependabot | ||
| firebase_core: ^4.4.0 # Rolled by dependabot |
There was a problem hiding this comment.
did you mean to have this? It reads like depedabot will update this.
…update tests for consistency
) This much shows we can run tests against the backend implementation with fakes. * new package `packages/cocoon_integration_test` * moved fakes / models / etc to here * decoupled app_dart from appengine/mirrors via ClientContext abstraction. * implemented IntegrationHttpClient for in-memory client-server communication. * added FakeCacheService to avoid test flakiness. * added dashboard integration test for test suppression. Next PR includes changes to defang "dart:io" from `app_dart/lib/**` so we can run it in the browser with dev_dashboard.
List of sha's with its guard status and creation timestamp to fill dropdown with sha's on a dashboard presubmit view Partial Fix: flutter/flutter#176990
2 participants
Draft unified check-runs UI implementation
Fix: flutter/flutter#176983