176983 Draft unified check-runs UI

analysis_options.yaml

@@ -12,6 +12,7 @@ analyzer:
     avoid_dynamic_calls: ignore
     comment_references: ignore
     deprecated_member_use_from_same_package: ignore
+    duplicate_ignore: ignore
     lines_longer_than_80_chars: ignore
     only_throw_errors: ignore
   exclude:

app_dart/bin/gae_server.dart

@@ -9,7 +9,8 @@ import 'package:cocoon_server/google_auth_provider.dart';
 import 'package:cocoon_server/secret_manager.dart';
 import 'package:cocoon_service/cocoon_service.dart';
 import 'package:cocoon_service/server.dart';
-import 'package:cocoon_service/src/request_handling/dashboard_authentication.dart';
+import 'package:cocoon_service/src/foundation/appengine_utils.dart';
+import 'package:cocoon_service/src/foundation/providers.dart';
 import 'package:cocoon_service/src/service/big_query.dart';
 import 'package:cocoon_service/src/service/build_status_service.dart';
 import 'package:cocoon_service/src/service/commit_service.dart';
@@ -24,6 +25,8 @@ Future<void> main() async {
   await withAppEngineServices(() async {
     useLoggingPackageAdaptor();
 
+    Providers.contextProvider = () => AppEngineClientContext(context);
+
     // This is bad, and I should feel bad, but I won't because the logging system
     // is inherently bad. We're allocating the logger (or getting back one) and
     // then turning it off - there is no way to "filter". Luckily; the library

app_dart/lib/cocoon_service.dart

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+export 'src/foundation/context.dart';
 export 'src/foundation/utils.dart';
 export 'src/request_handlers/check_flaky_builders.dart';
 export 'src/request_handlers/create_branch.dart';
@@ -32,6 +33,8 @@ export 'src/request_handlers/update_existing_flaky_issues.dart';
 export 'src/request_handlers/vacuum_github_commits.dart';
 export 'src/request_handling/authentication.dart';
 export 'src/request_handling/cache_request_handler.dart';
+export 'src/request_handling/checkrun_authentication.dart';
+export 'src/request_handling/dashboard_authentication.dart';
 export 'src/request_handling/pubsub.dart';
 export 'src/request_handling/pubsub_authentication.dart';
 export 'src/request_handling/request_handler.dart';

app_dart/lib/server.dart

@@ -9,6 +9,7 @@ import 'cocoon_service.dart';
 import 'src/request_handlers/get_engine_artifacts_ready.dart';
 import 'src/request_handlers/get_presubmit_checks.dart';
 import 'src/request_handlers/get_presubmit_guard.dart';
+import 'src/request_handlers/get_presubmit_guard_summaries.dart';
 import 'src/request_handlers/get_tree_status_changes.dart';
 import 'src/request_handlers/github_webhook_replay.dart';
 import 'src/request_handlers/lookup_hash.dart';
@@ -190,6 +191,11 @@ Server createServer({
       authenticationProvider: authProvider,
       firestore: firestore,
     ),
+    '/api/get-presubmit-guard-summaries': GetPresubmitGuardSummaries(
+      config: config,
+      authenticationProvider: authProvider,
+      firestore: firestore,
+    ),
     '/api/get-presubmit-checks': GetPresubmitChecks(
       config: config,
       authenticationProvider: authProvider,

app_dart/lib/src/foundation/appengine_utils.dart

@@ -0,0 +1,15 @@
+// Copyright 2026 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'package:appengine/appengine.dart' as gae;
+
+import 'context.dart';
+
+class AppEngineClientContext implements ClientContext {
+  final gae.ClientContext _context;
+  AppEngineClientContext(this._context);
+
+  @override
+  bool get isDevelopmentEnvironment => _context.isDevelopmentEnvironment;
+}

app_dart/lib/src/foundation/context.dart

@@ -0,0 +1,12 @@
+// Copyright 2026 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/// A context for the current request.
+///
+/// This abstracts the underlying App Engine context to avoid direct dependencies
+/// on package:appengine in core logic.
+abstract class ClientContext {
+  /// Whether the application is running in the development environment.
+  bool get isDevelopmentEnvironment;
+}

app_dart/lib/src/foundation/providers.dart

@@ -2,9 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import 'package:appengine/appengine.dart' as gae;
 import 'package:http/http.dart' as http;
 
+import 'context.dart';
 import 'typedefs.dart';
 
 /// Class that holds static default providers.
@@ -18,17 +18,16 @@ class Providers {
   ///  * [HttpClientProvider], which defines this interface.
   static http.Client freshHttpClient() => http.Client();
 
-  /// Default [gae.Logging] provider.
+  /// Initializes the [ClientContext] provider.
   ///
-  /// See also:
-  ///
-  ///  * [LoggingProvider], which defines this interface.
-  static gae.Logging serviceScopeLogger() => gae.loggingService;
+  /// This must be called before [serviceScopeContext] is used.
+  static ClientContextProvider contextProvider = () =>
+      throw UnimplementedError('ClientContext provider not initialized');
 
-  /// Default [gae.ClientContext] provider.
+  /// Default [ClientContext] provider.
   ///
   /// See also:
   ///
   ///  * [ClientContextProvider], which defines this interface.
-  static gae.ClientContext serviceScopeContext() => gae.context;
+  static ClientContext serviceScopeContext() => contextProvider();
 }

app_dart/lib/src/foundation/typedefs.dart

@@ -2,9 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import 'package:appengine/appengine.dart';
 import 'package:http/http.dart' as http;
 
+import 'context.dart';
+
 /// Signature for a function that returns an App Engine [ClientContext].
 ///
 /// This is used in [AuthenticationProvider] to provide the client context

app_dart/lib/src/request_handlers/get_presubmit_guard.dart

@@ -63,18 +63,18 @@ final class GetPresubmitGuard extends ApiRequestHandler {
     // Consolidate metadata from the first record.
     final first = guards.first;
 
-    final GuardStatus guardStatus;
-    if (guards.any((g) => g.failedBuilds > 0)) {
-      guardStatus = GuardStatus.failed;
-    } else if (guards.every(
-      (g) => g.failedBuilds == 0 && g.remainingBuilds == 0,
-    )) {
-      guardStatus = GuardStatus.succeeded;
-    } else if (guards.every((g) => g.remainingBuilds == g.builds.length)) {
-      guardStatus = GuardStatus.waitingForBackfill;
-    } else {
-      guardStatus = GuardStatus.inProgress;
-    }
+    final totalFailed = guards.fold<int>(0, (sum, g) => sum + g.failedBuilds);
+    final totalRemaining = guards.fold<int>(
+      0,
+      (sum, g) => sum + g.remainingBuilds,
+    );
+    final totalBuilds = guards.fold<int>(0, (sum, g) => sum + g.builds.length);
+
+    final guardStatus = GuardStatus.calculate(
+      failedBuilds: totalFailed,
+      remainingBuilds: totalRemaining,
+      totalBuilds: totalBuilds,
+    );
 
     final response = rpc_model.PresubmitGuardResponse(
       prNum: first.pullRequestId,

app_dart/lib/src/request_handlers/get_presubmit_guard_summaries.dart

@@ -0,0 +1,112 @@
+// Copyright 2026 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'dart:async';
+import 'dart:io';
+import 'dart:math';
+
+import 'package:cocoon_common/guard_status.dart';
+import 'package:cocoon_common/rpc_model.dart' as rpc_model;
+import 'package:github/github.dart';
+import 'package:meta/meta.dart';
+
+import '../../cocoon_service.dart';
+import '../model/firestore/presubmit_guard.dart';
+import '../request_handling/api_request_handler.dart';
+import '../service/firestore/unified_check_run.dart';
+
+/// Request handler for retrieving all presubmit guards for a specific pull request.
+///
+/// GET: /api/get-presubmit-guard-summaries
+///
+/// Parameters:
+///   repo: (string in query) required. The repository name (e.g., 'flutter').
+///   pr: (int in query) required. The pull request number.
+///   owner: (string in query) optional. The repository owner (e.g., 'flutter').
+@immutable
+final class GetPresubmitGuardSummaries extends ApiRequestHandler {
+  /// Defines the [GetPresubmitGuardSummaries] handler.
+  const GetPresubmitGuardSummaries({
+    required super.config,
+    required super.authenticationProvider,
+    required FirestoreService firestore,
+  }) : _firestore = firestore;
+
+  final FirestoreService _firestore;
+
+  /// The name of the query parameter for the repository name (e.g. 'flutter').
+  static const String kRepoParam = 'repo';
+
+  /// The name of the query parameter for the pull request number.
+  static const String kPRParam = 'pr';
+
+  /// The name of the query parameter for the repository owner (e.g. 'flutter').
+  static const String kOwnerParam = 'owner';
+
+  @override
+  Future<Response> get(Request request) async {
+    checkRequiredQueryParameters(request, [kRepoParam, kPRParam]);
+
+    final repo = request.uri.queryParameters[kRepoParam]!;
+    final prNumber = int.parse(request.uri.queryParameters[kPRParam]!);
+    final owner = request.uri.queryParameters[kOwnerParam] ?? 'flutter';
+
+    final slug = RepositorySlug(owner, repo);
+    final guards = await UnifiedCheckRun.getPresubmitGuardsForPullRequest(
+      firestoreService: _firestore,
+      slug: slug,
+      pullRequestId: prNumber,
+    );
+
+    if (guards.isEmpty) {
+      return Response.json({
+        'error': 'No guards found for PR $prNumber in $slug',
+      }, statusCode: HttpStatus.notFound);
+    }
+
+    // Group guards by commitSha
+    final groupedGuards = <String, List<PresubmitGuard>>{};
+    for (final guard in guards) {
+      groupedGuards.putIfAbsent(guard.commitSha, () => []).add(guard);
+    }
+
+    final responseGuards = <rpc_model.PresubmitGuardSummary>[];
+    for (final entry in groupedGuards.entries) {
+      final sha = entry.key;
+      final shaGuards = entry.value;
+
+      final totalFailed = shaGuards.fold<int>(
+        0,
+        (int sum, PresubmitGuard g) => sum + g.failedBuilds,
+      );
+      final totalRemaining = shaGuards.fold<int>(
+        0,
+        (int sum, PresubmitGuard g) => sum + g.remainingBuilds,
+      );
+      final totalBuilds = shaGuards.fold<int>(
+        0,
+        (int sum, PresubmitGuard g) => sum + g.builds.length,
+      );
+      final earliestCreationTime = shaGuards.fold<int>(
+        // assuming creation time is always in the past :)
+        DateTime.now().millisecondsSinceEpoch,
+        (int curr, PresubmitGuard g) => min(g.creationTime, curr),
+      );
+
+      responseGuards.add(
+        rpc_model.PresubmitGuardSummary(
+          commitSha: sha,
+          creationTime: earliestCreationTime,
+          guardStatus: GuardStatus.calculate(
+            failedBuilds: totalFailed,
+            remainingBuilds: totalRemaining,
+            totalBuilds: totalBuilds,
+          ),
+        ),
+      );
+    }
+
+    return Response.json(responseGuards);
+  }
+}

app_dart/lib/src/request_handling/authentication.dart

@@ -5,9 +5,9 @@
 import 'dart:async';
 import 'dart:io';
 
-import 'package:appengine/appengine.dart';
 import 'package:meta/meta.dart';
 
+import '../foundation/context.dart';
 import 'exceptions.dart';
 
 @immutable

app_dart/lib/src/request_handling/checkrun_authentication.dart

@@ -5,7 +5,6 @@
 import 'dart:async';
 import 'dart:io';
 
-import 'package:appengine/appengine.dart';
 import 'package:cocoon_server/logging.dart';
 import 'package:github/github.dart';
 import 'package:meta/meta.dart';
@@ -15,7 +14,6 @@ import '../foundation/providers.dart';
 import '../foundation/typedefs.dart';
 import '../model/google/token_info.dart';
 import '../service/firebase_jwt_validator.dart';
-import 'dashboard_authentication.dart';
 import 'exceptions.dart';
 
 /// Class capable of authenticating [HttpRequest]s from the Checkrun page.

app_dart/lib/src/request_handling/dashboard_authentication.dart

@@ -5,7 +5,6 @@
 import 'dart:async';
 import 'dart:io';
 
-import 'package:appengine/appengine.dart';
 import 'package:cocoon_server/logging.dart';
 import 'package:meta/meta.dart';
 

app_dart/lib/src/request_handling/pubsub_authentication.dart

@@ -5,7 +5,6 @@
 import 'dart:async';
 import 'dart:io';
 
-import 'package:appengine/appengine.dart';
 import 'package:cocoon_server/logging.dart';
 import 'package:googleapis/oauth2/v2.dart';
 import 'package:meta/meta.dart';

app_dart/lib/src/request_handling/swarming_authentication.dart

@@ -6,7 +6,6 @@ import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
-import 'package:appengine/appengine.dart';
 import 'package:cocoon_server/logging.dart';
 import 'package:meta/meta.dart';
 

app_dart/lib/src/service/firestore/unified_check_run.dart

@@ -243,6 +243,19 @@ final class UnifiedCheckRun {
     );
   }
 
+  /// Queries for [PresubmitGuard] records by [slug] and [pullRequestId].
+  static Future<List<PresubmitGuard>> getPresubmitGuardsForPullRequest({
+    required FirestoreService firestoreService,
+    required RepositorySlug slug,
+    required int pullRequestId,
+  }) async {
+    return await _queryPresubmitGuards(
+      firestoreService: firestoreService,
+      slug: slug,
+      pullRequestId: pullRequestId,
+    );
+  }
+
   static Future<List<PresubmitGuard>> _queryPresubmitGuards({
     required FirestoreService firestoreService,
     Transaction? transaction,

app_dart/pubspec.yaml

@@ -57,6 +57,8 @@ dev_dependencies:
   build_runner: ^2.4.15
   cocoon_common_test:
     path: ../packages/cocoon_common_test
+  cocoon_integration_test:
+    path: ../packages/cocoon_integration_test
   cocoon_server_test:
     path: ../packages/cocoon_server_test
   dart_flutter_team_lints: 3.5.2

app_dart/test/foundation/utils_test.dart

@@ -7,6 +7,7 @@ import 'dart:io';
 
 import 'package:cocoon_common/cocoon_common.dart';
 import 'package:cocoon_common_test/cocoon_common_test.dart';
+import 'package:cocoon_integration_test/testing.dart';
 import 'package:cocoon_server/logging.dart';
 import 'package:cocoon_server_test/test_logging.dart';
 import 'package:cocoon_service/src/foundation/utils.dart';
@@ -18,9 +19,6 @@ import 'package:http/testing.dart';
 import 'package:retry/retry.dart';
 import 'package:test/test.dart';
 
-import '../src/bigquery/fake_tabledata_resource.dart';
-import '../src/utilities/entity_generators.dart';
-
 const String branchRegExp = '''
       master
       flutter-1.1-candidate.1

app_dart/test/model/ci_yaml/ci_yaml_test.dart

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import 'package:cocoon_integration_test/testing.dart';
 import 'package:cocoon_server_test/test_logging.dart';
 import 'package:cocoon_service/protos.dart' as pb;
 import 'package:cocoon_service/src/model/ci_yaml/ci_yaml.dart';
@@ -10,9 +11,6 @@ import 'package:cocoon_service/src/service/config.dart';
 import 'package:cocoon_service/src/service/flags/ci_yaml_flags.dart';
 import 'package:test/test.dart';
 
-import '../../src/model/ci_yaml_matcher.dart';
-import '../../src/service/fake_scheduler.dart';
-
 void main() {
   useTestLoggerPerTest();