Open
Conversation
29517d9 to
a2b6e44
Compare
vkedwardli
commented
Mar 20, 2026
a2b6e44 to
88af8b7
Compare
88af8b7 to
78ccc0a
Compare
Collaborator
Author
Smoke Test (Win11 UWP)
Before
Xbox:
After
Xbox:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmtlibto replacestd::format(which is not supported on macOS < 13.3)/WHOLEARCHIVEfor SDL2 to fix metadata stripping in C++20 buildsDreamPicoPort-APIto fix C++20 template errors (will wait for upstream)Following PR #1696, I thought I could use designated initializers since the project is now C++20, but MSVC is very strict with the feature set. This is another attempt to fix what PR #1868 missed.
Looking for feedback on these C++20 workarounds and would like to confirm if this strategy aligns with the project's direction.
I concern that with C++20 enabled, contributors will naturally use
std::format, they might wait hours for a full build only discover the macOS CI to fail late in the process, sostd::to_charsis missingstd::formatvia Header Guards so whenever someone try to compile, so error pops up immediately? Or pre-commit hook with CMake script?p.s. The UWP build can be run on a Windows 11 machine, can play games, not sure what actions are required to verify the UWP build since I don't have an Xbox