Skip to content

fix(ui): Make a single command for ssh access dialog - #7233

Merged
siduck merged 5 commits into
developfrom
fix-ui
Aug 19, 2026
Merged

fix(ui): Make a single command for ssh access dialog#7233
siduck merged 5 commits into
developfrom
fix-ui

Conversation

@siduck

@siduck siduck commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator
image

Bench row in sites overview

image

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (5): Last reviewed commit: "misc" | Re-trigger Greptile

Comment thread dashboard/src/components/group/SSHCertificateDialog.vue Outdated
@mergify

mergify Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov-commenter

codecov-commenter commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.30%. Comparing base (a50cefa) to head (743cc48).
⚠️ Report is 32 commits behind head on develop.

Files with missing lines Patch % Lines
...oard/src/components/group/SSHCertificateDialog.vue 54.16% 11 Missing ⚠️

❌ Your patch status has failed because the patch coverage (54.16%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7233       +/-   ##
============================================
+ Coverage    59.71%   87.30%   +27.58%     
============================================
  Files         1019      126      -893     
  Lines        93663    22965    -70698     
  Branches      1216     1215        -1     
============================================
- Hits         55930    20049    -35881     
+ Misses       37710     2893    -34817     
  Partials        23       23               
Flag Coverage Δ
dashboard 87.30% <54.16%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if (!this.certificateCommand || !this.sshCommand) return null
if (this.isWindows) {
const setEncoding = "$PSDefaultParameterValues['*: Encoding'] = 'utf8'"
return `${setEncoding}; ${this.certificateCommand}; if ($?) { ${this.sshCommand} }`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 PowerShell writes certificate outside home

When a Windows user runs this command, PowerShell treats the redirection target ~/.ssh/... as a literal relative path instead of $HOME/.ssh, so the certificate write either fails and prevents SSH from starting or stores the certificate where SSH will not find it.

Suggested change
return `${setEncoding}; ${this.certificateCommand}; if ($?) { ${this.sshCommand} }`
return `${setEncoding}; ${this.certificateCommand.replace('~/', '$HOME/')}; if ($?) { ${this.sshCommand} }`

Fix in Claude Code Fix in Codex

@siduck
siduck merged commit 570aa62 into develop Aug 19, 2026
2 of 4 checks passed
@siduck
siduck deleted the fix-ui branch August 19, 2026 08:25
@siduck

siduck commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

@mergify backport master

@siduck
siduck restored the fix-ui branch August 19, 2026 08:25
@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

backport master

✅ Backports have been created

Details

Cherry-pick of 5b9e2c0 has failed:

On branch mergify/bp/master/pr-7233
Your branch is ahead of 'origin/master' by 2 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 5b9e2c084.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   dashboard/src/components/BenchActionsDropdown.vue
	modified:   dashboard/src/components/SiteOverview.vue

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   dashboard/src/objects/common/types.ts
	both modified:   dashboard/src/pages/ReleaseGroupBenchSites.vue

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

siduck added a commit that referenced this pull request Aug 19, 2026
fix(ui): Make a single command for ssh access dialog (backport #7233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants