Conversation
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (5): Last reviewed commit: "misc" | Re-trigger Greptile |
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (54.16%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7233 +/- ##
============================================
+ Coverage 59.71% 87.30% +27.58%
============================================
Files 1019 126 -893
Lines 93663 22965 -70698
Branches 1216 1215 -1
============================================
- Hits 55930 20049 -35881
+ Misses 37710 2893 -34817
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| if (!this.certificateCommand || !this.sshCommand) return null | ||
| if (this.isWindows) { | ||
| const setEncoding = "$PSDefaultParameterValues['*: Encoding'] = 'utf8'" | ||
| return `${setEncoding}; ${this.certificateCommand}; if ($?) { ${this.sshCommand} }` |
There was a problem hiding this comment.
PowerShell writes certificate outside home
When a Windows user runs this command, PowerShell treats the redirection target ~/.ssh/... as a literal relative path instead of $HOME/.ssh, so the certificate write either fails and prevents SSH from starting or stores the certificate where SSH will not find it.
| return `${setEncoding}; ${this.certificateCommand}; if ($?) { ${this.sshCommand} }` | |
| return `${setEncoding}; ${this.certificateCommand.replace('~/', '$HOME/')}; if ($?) { ${this.sshCommand} }` |
|
@mergify backport master |
✅ Backports have been createdDetails
Cherry-pick of 5b9e2c0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
fix(ui): Make a single command for ssh access dialog (backport #7233)
Bench row in sites overview