Skip to content

fix(ui): Make a single command for ssh access dialog (backport #7233) - #7267

Merged
siduck merged 5 commits into
masterfrom
mergify/bp/master/pr-7233
Aug 19, 2026
Merged

fix(ui): Make a single command for ssh access dialog (backport #7233)#7267
siduck merged 5 commits into
masterfrom
mergify/bp/master/pr-7233

Conversation

@mergify

@mergify mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor
image

Bench row in sites overview

image
This is an automatic backport of pull request #7233 done by [Mergify](https://mergify.com).

siduck added 4 commits August 19, 2026 08:26
(cherry picked from commit 5b9e2c0)

# Conflicts:
#	dashboard/src/objects/common/types.ts
#	dashboard/src/pages/ReleaseGroupBenchSites.vue
(cherry picked from commit 169729d)
@mergify
mergify Bot requested a review from siduck as a code owner August 19, 2026 08:26
@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 5b9e2c0 has failed:

On branch mergify/bp/master/pr-7233
Your branch is ahead of 'origin/master' by 2 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 5b9e2c084.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   dashboard/src/components/BenchActionsDropdown.vue
	modified:   dashboard/src/components/SiteOverview.vue

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   dashboard/src/objects/common/types.ts
	both modified:   dashboard/src/pages/ReleaseGroupBenchSites.vue

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@siduck

siduck commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

@greptile-apps fixed the cherry pick on mergify branch now review!

@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge; no actionable changed-code defect was established.

The centralized action behavior retains backend permission and public-server safeguards, and the SSH command consolidation preserves the prior command sequence.

Reviews (1): Last reviewed commit: "fix(ui): Resolve backport conflicts in b..." | Re-trigger Greptile

@siduck
siduck merged commit de99004 into master Aug 19, 2026
6 checks passed
@siduck
siduck deleted the mergify/bp/master/pr-7233 branch August 19, 2026 08:40
@frappe-pr-bot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 0.106.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.10204% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.64%. Comparing base (938f3f6) to head (83796eb).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...rd/src/components/group/BenchAppVersionsDialog.vue 15.68% 43 Missing ⚠️
dashboard/src/components/SiteOverview.vue 7.69% 12 Missing ⚠️
...oard/src/components/group/SSHCertificateDialog.vue 54.16% 11 Missing ⚠️

❌ Your patch status has failed because the patch coverage (55.10%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7267       +/-   ##
===========================================
+ Coverage   59.04%   87.64%   +28.60%     
===========================================
  Files        1027      129      -898     
  Lines       94063    22917    -71146     
  Branches     1264     1266        +2     
===========================================
- Hits        55539    20086    -35453     
+ Misses      38496     2802    -35694     
- Partials       28       29        +1     
Flag Coverage Δ
dashboard 87.64% <55.10%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants