Skip to content

feat!: update models to vrs 2.0.0 community review ballot #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
korikuzma merged 12 commits into from
Dec 20, 2024
Merged

feat!: update models to vrs 2.0.0 community review ballot #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e641fb7
update submodule to 2.0.0-ballot.2024-11.2 (991047c)
korikuzma Dec 17, 2024
d7e7152
wip: initial work for updating models
korikuzma Dec 18, 2024
9d12205
wip: cleanup
korikuzma Dec 18, 2024
f6b0e55
wip: update submodule
korikuzma Dec 18, 2024
0c44142
wip: get tests to pass
korikuzma Dec 18, 2024
6d7b08a
wip: spelling
korikuzma Dec 18, 2024
de730cb
more updates
korikuzma Dec 18, 2024
4bad15b
add adjacency test
korikuzma Dec 18, 2024
c06d43c
rm date/datetime
korikuzma Dec 18, 2024
f4dae80
rename _Ga4ghIdentifiableObject -> Ga4ghIdentifiableObject
korikuzma Dec 18, 2024
39c1ffd
update gitmodules to 2.0.0-ballot.2024-11.3 tag
korikuzma Dec 19, 2024
86b99a1
add return type in docstring
korikuzma Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[submodule "submodules/vrs"]
path = submodules/vrs
url = https://github.com/ga4gh/vrs.git
branch = 2.x
branch = 2.0.0-ballot.2024-11
Copy link
Contributor

@jsstevenson jsstevenson Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why we're pinning a branch and not a tag? I'd think we would want to be pinning specific commits. Submodules always hurt my brain though so maybe I'm misunderstanding.

(ditto for VRS -> gks-core, outside scope of this PR though obviously)

Copy link
Contributor Author

@korikuzma korikuzma Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have missed something when googling before but tags aren't supported in .gitmodules so I opted for the branch

Copy link
Contributor

@jsstevenson jsstevenson Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can punt this to an issue but I think commit would be appropriate (and it's effectively the same as a tag name). Otherwise there's a risk that changes to the submodule'd branch run ahead of what's expected in the superproject.

7 changes: 2 additions & 5 deletions src/ga4gh/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
from .pydantic import (
is_pydantic_instance, is_curie_type, pydantic_copy
)
from .domain_models import CommonDomainType
from . import entity_models, domain_models
from . import models as core_models

__all__ = [
"sha512t24u",
Expand All @@ -37,9 +36,7 @@
"is_pydantic_instance",
"is_curie_type",
"pydantic_copy",
"CommonDomainType",
"entity_models",
"domain_models"
"core_models",
]

try:
Expand Down
131 changes: 0 additions & 131 deletions src/ga4gh/core/domain_models.py
View file
Open in desktop

This file was deleted.

Loading
Loading