feat!: update models to vrs 2.0.0 community review ballot

[korikuzma]

close #469

• Update modules to vrs 2.0.0-ballot.2024-11.3 tag
• Rename class _Ga4ghIdentifiableObject to Ga4ghIdentifiableObject
• Removes entity_models and domain_models from ga4gh.core. Now, all gks-core models are in ga4gh.core.models.
  • gks-core includes date and datetime as primitives, however the builtin datetime module already provides these. Initially, I kept them as Pydantic Root Models but I think we should just leverage the datetime module instead.

[korikuzma]

VRS 2.0.0-ballot.2024-11.3 will be made later tonight. Will update submodules afterwards

[jsstevenson]

2 small requested changes (typos) and a few recommendations

[jsstevenson]

is there a reason why we're pinning a branch and not a tag? I'd think we would want to be pinning specific commits. Submodules always hurt my brain though so maybe I'm misunderstanding.

(ditto for VRS -> gks-core, outside scope of this PR though obviously)

[korikuzma]

I might have missed something when googling before but tags aren't supported in .gitmodules so I opted for the branch

[jsstevenson]

maybe we can punt this to an issue but I think commit would be appropriate (and it's effectively the same as a tag name). Otherwise there's a risk that changes to the submodule'd branch run ahead of what's expected in the superproject.

[jsstevenson]

👍 reasonable on all fronts. looks good to merge on my end