Tagged RTC DH bits as r/w - #81
Closed
nummacway wants to merge 1 commit into
Closed
Conversation
Also moved affected RAMB_RTC_DH bit constants to rRTCREG, since their placement under rRAMB is clearly an error
Member
|
I think the rationale for the current layout is that any defines specific to any of the selected registers would be placed next to the define for selecting the corresponding register. Not 100% sold on either way, personally; I see advantages to both. |
avivace
requested changes
Jan 1, 2026
avivace
left a comment
avivace
left a comment
Member
There was a problem hiding this comment.
Please split the changes regarding the 'move' in another PR. It's not 'clearly' an error but we can discuss about shifting rationale.
This PR should only have the 'r/w' change.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moved affected RAMB_RTC_DH bit constants to rRTCREG, since their placement under rRAMB is clearly an error