Rename RAMB_RTC_DH_* flags to RTCREG_DH_* - #92
Merged
Conversation
Collaborator
Author
|
An example from pokecrystal: StartRTC:
ld a, RAMG_SRAM_ENABLE
ld [rRAMG], a
call LatchClock
ld a, RAMB_RTC_DH
ld [rRAMB], a
ld a, [rRTCREG]
res B_RAMB_RTC_DH_HALT, a
ld [rRTCREG], a
call CloseSRAM
retThis would make more sense after a rename: StartRTC:
ld a, RAMG_SRAM_ENABLE
ld [rRAMG], a
call LatchClock
ld a, RAMB_RTC_DH
ld [rRAMB], a
ld a, [rRTCREG]
res B_RTCREG_DH_HALT, a
ld [rRTCREG], a
call CloseSRAM
ret |
avivace
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #81.
These flag bits apply to the value mapped into
[rRTCREG], not the value of[rRAMB].rRAMBis only involved because writing theRAMB_RTC_DHsentinel value to it maps the RTC DH flags into[rRTCREG].