-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: App start definitions for iOS and Android #15798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment
| - **UIKit Init**: from pre main initializers to the when starting the Sentry Cocoa SDK. | ||
| - **Application Init**: this reflects the duration of your AppDelegate `application:didFinishLaunchingWithOptions` method or [App conformer's initializer](<https://developer.apple.com/documentation/swiftui/app/main()>) when using SwiftUI, which is from when starting the Cocoa SDK to the [`didFinishLaunchingNotification`][didfinishlaunching]. | ||
| - **Initial Frame Render**: from the [`didFinishLaunchingNotification`][didfinishlaunching] until the app renders its first frame. **Starting with version 9.0.0, this is the default behavior.** In versions prior to 9.0.0, this measured until [`UIWindowDidBecomeVisibleNotification`][uiwindow] unless you enabled the `enablePerformanceV2` option. | ||
| - **Initial Frame Render**: from the [`didFinishLaunchingNotification`][didfinishlaunching] until the first CADisplayLink callback. **Starting with version 9.0.0, this is the default behavior.** In versions prior to 9.0.0, this measured until [`UIWindowDidBecomeVisibleNotification`][uiwindow] unless you enabled the `enablePerformanceV2` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: While this is technically more correct, it requires app developers to understand what a CADisplayLink is
| ### `measurements.app_start_cold` | ||
|
|
||
| A [cold start](/product/insights/mobile/mobile-vitals/app-starts/) refers to when the app launches for the first time after a reboot or update. The app is not in memory and no process exists. | ||
| A [cold start](/product/insights/mobile/mobile-vitals/app-starts/) on Android refers to when the app process is creatd from scratch. On iOS it is only the first time a process is created after a reboot or update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| A [cold start](/product/insights/mobile/mobile-vitals/app-starts/) on Android refers to when the app process is creatd from scratch. On iOS it is only the first time a process is created after a reboot or update. | |
| A [cold start](/product/insights/mobile/mobile-vitals/app-starts/) on Android refers to when the app process is created from scratch. On iOS it is only the first time a process is created after a reboot or update. |
DESCRIBE YOUR PR
Corrects the definitions of cold/warm starts
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: