-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: App start definitions for iOS and Android #15798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noahsmartin
wants to merge
1
commit into
master
Choose a base branch
from
clearlyExplainAppStart
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,8 +102,8 @@ To enable this feature, enable `enableAutoPerformanceTracing`. | |
|
|
||
| The SDK differentiates between a cold and a warm start, but doesn't track hot starts/resumes. | ||
|
|
||
| - **Cold start**: App launched for the first time, after a reboot or update. The app is not in memory and no process exists. | ||
| - **Warm start**: App launched at least once, is partially in memory, and no process exists. | ||
| - **Cold start**: App launched for the first time, after a reboot or update. A cold start begins when the process is created. | ||
| - **Warm start**: Any time the process is created that isn’t a cold start. | ||
|
|
||
| <Alert> | ||
|
|
||
|
|
@@ -118,7 +118,7 @@ The Cocoa SDK creates the following app start spans: | |
| - **Runtime Init to Pre Main Initializers**: from runtime init to pre main initializers. | ||
| - **UIKit Init**: from pre main initializers to the when starting the Sentry Cocoa SDK. | ||
| - **Application Init**: this reflects the duration of your AppDelegate `application:didFinishLaunchingWithOptions` method or [App conformer's initializer](<https://developer.apple.com/documentation/swiftui/app/main()>) when using SwiftUI, which is from when starting the Cocoa SDK to the [`didFinishLaunchingNotification`][didfinishlaunching]. | ||
| - **Initial Frame Render**: from the [`didFinishLaunchingNotification`][didfinishlaunching] until the app renders its first frame. **Starting with version 9.0.0, this is the default behavior.** In versions prior to 9.0.0, this measured until [`UIWindowDidBecomeVisibleNotification`][uiwindow] unless you enabled the `enablePerformanceV2` option. | ||
| - **Initial Frame Render**: from the [`didFinishLaunchingNotification`][didfinishlaunching] until the first CADisplayLink callback. **Starting with version 9.0.0, this is the default behavior.** In versions prior to 9.0.0, this measured until [`UIWindowDidBecomeVisibleNotification`][uiwindow] unless you enabled the `enablePerformanceV2` option. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
|  | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.