chore(deps): update Cocoa SDK to v9.2.0#4781
Conversation
1275f51 to
908db8e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4781 +/- ##
==========================================
- Coverage 73.86% 73.84% -0.03%
==========================================
Files 496 496
Lines 17927 17927
Branches 3511 3511
==========================================
- Hits 13242 13238 -4
- Misses 3824 3831 +7
+ Partials 861 858 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2c065e1 to
a1354a2
Compare
f93b518 to
501a073
Compare
ed18d9f to
432f685
Compare
cc7ea2d to
b821ecd
Compare
720e4a0 to
a30f01d
Compare
509f0c9 to
fe091a7
Compare
fe091a7 to
76b917d
Compare
1c85ec4 to
dc6c357
Compare
f4ed890 to
117130f
Compare
117130f to
4ff6050
Compare
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: GitHub <noreply@github.com>
Aside from the conversation about transaction based profiling, is this ready to be merged @jpnurmi ? |
Cocoa SDK v9 bumped the minimum iOS version to 15.0. Sentry .NET should probably bump |
Yeah we can/should definitely do that then 👍🏻 |
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Dependencies ⬆️Deps
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
Looks good to me. @Flash0ver you maybe want to take a look as well... probably a PR that deserves a good review before merging. |
Flash0ver
left a comment
There was a problem hiding this comment.
Well done 🥔. I got two comments (because of course I do 😉).
| <PropertyGroup Condition="'$(TargetFramework)' != ''"> | ||
| <TargetPlatformIdentifier>$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)'))</TargetPlatformIdentifier> | ||
| <SupportedOSPlatformVersion Condition="'$(TargetPlatformIdentifier)' == 'ios'">13.0</SupportedOSPlatformVersion> | ||
| <SupportedOSPlatformVersion Condition="'$(TargetPlatformIdentifier)' == 'ios'">15.0</SupportedOSPlatformVersion> |
There was a problem hiding this comment.
question: breaking change?
Just to be sure ... now that I actually write it down I don't think there is a breaking change for .NET MAUI 9 or .NET MAUI 10 consumers, but just to be sure:
Cocoa SDK v9 bumped the minimum iOS version to 15.0. Sentry .NET should probably bump
SupportedOSPlatformVersionaccordingly?
Yeah we can/should definitely do that then 👍🏻
In this Directory.Build.props, we declare:
sentry-dotnet/Directory.Build.props
Lines 33 to 36 in 87249e6
In the .NET MAUI SDK Sentry.Maui, we then use:
sentry-dotnet/src/Sentry.Maui/Sentry.Maui.csproj
Lines 9 to 13 in 87249e6
Just to make sure:
Our in this changeset unchanged iOS and Mac Catalyst version is 18.0 for .NET 9 (and 26.0 for .NET 10),
and now bumping sentry-cocoa to 9.2.0, where 9.0.0 notes
### Breaking Changes
- Bumped minimum OS versions to iOS 15.0, macOS 10.14.0, tvOS 15.0, visionOS 1.0, and watchOS 8.0 (https://github.com/getsentry/sentry-cocoa/pull/6873)
we are not introducing any breaking changes, are we?
Also considering the related conversation from the preceding changeset of
And also considering the Supported platforms for .NET MAUI apps.
There was a problem hiding this comment.
Apart from #4781 (comment), on which I'll follow up on Monday.
There was a problem hiding this comment.
It means anyone using the apps developed by Sentry SDK customers would need to upgrades from iOS 13 to 15 in order to be able to continue to use those apps... so it's not breaking for our SDK users and it's just part of the normal phasing out of old platforms for Apple.
Bumps modules/sentry-cocoa.properties from 8.57.3 to 9.2.0.
Auto-generated by a dependency updater.
Changelog Entry