chore: Use SLNX format for solution files#4911
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
| var assembly = typeof(AttributeReaderTests).Assembly; | ||
| Assert.NotNull(AttributeReader.TryGetProjectDirectory(assembly)); |
There was a problem hiding this comment.
issue: test without assertion
Intended?
Should we run test in Release mode, could typeof(AttributeReaderTests).Assembly be removed?
There was a problem hiding this comment.
Worryingly, the dotnet format tool did this, according to the commit history!
There was a problem hiding this comment.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4911 +/- ##
==========================================
- Coverage 73.88% 73.86% -0.02%
==========================================
Files 494 494
Lines 17868 17868
Branches 3509 3509
==========================================
- Hits 13202 13199 -3
- Misses 3807 3809 +2
- Partials 859 860 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This reverts commit 7a0cec0.
jamescrosswell
force-pushed
the
slnx-files
branch
from
7fe6759 to
704d35f
Compare
Flash0ver
left a comment
Flash0ver
left a comment
There was a problem hiding this comment.
✅ with some non-blocking questions for potential follow-ups
| # We exclude `test/Sentry.Tests/AttributeReaderTests.cs` because dotnet-format tries to | ||
| # delete assertions in there. | ||
| # - see https://github.com/getsentry/sentry-dotnet/pull/4911#discussion_r2795717887 | ||
| run: dotnet format Sentry.slnx --no-restore --exclude ./modules --exclude ./**/*OptionsSetup.cs --exclude ./test/Sentry.Tests/AttributeReaderTests.cs |
There was a problem hiding this comment.
note: will follow-up in #4918 ... maybe the .NET CLI-included command changes behavior there
3 participants
Resolves #4040:
#skip-changelog