Add golangci-lint configuration and appease some linters

[silkeh]

This PR adds configuration and a GitHub workflow action for golangci-lint. Trivially fixed linting issues have been fixed, and other linters disabled so they can be enabled with a little more care..

[livingsilver94]

Your linting PR was made against master, but I reworked the cli package in the relive branch, you should lint that branch instead.

[silkeh]

Your linting PR was made against master, but I reworked the cli package in the relive branch, you should lint that branch instead.

I don't understand: this PR is a standalone change that has little to do with the CLI overhaul. As such, it should generally go into master.

[livingsilver94]

You linted cli in master which was overhauled in relive, so your linting in that package is DOA. If you don't mind re-linting it after we've merged the branch, then it's all good 😄

[livingsilver94]

Should you not like the "temporary master branch" approach but prefer advancing the master in little steps, just lemme know and we'll go that way. My initial idea was to resume working on usysconf in relive and eventually merge it into master.

[silkeh]

You linted cli in master which was overhauled in relive, so your linting in that package is DOA. If you don't mind re-linting it after we've merged the branch, then it's all good 😄

That's fine, these changes can wait 🙂

Should you not like the "temporary master branch" approach but prefer advancing the master in little steps, just lemme know and we'll go that way. My initial idea was to resume working on usysconf in relive and eventually merge it into master.

Personally, I would reserve the 'temporary master branch' (or 'long-lived feature branch') approach for when master is actively being developed and/or changes are likely to subtly break things. That doesn't seem the case here, so I would just advance master in little steps.

[silkeh]

@livingsilver94: I have rebased on the latest master. GLHF 😉