Skip to content

feat: add firebender checkpoint preset alias#804

Open
anishfish2 wants to merge 3 commits intogit-ai-project:mainfrom
anishfish2:feat/firebender-agent-support
Open

feat: add firebender checkpoint preset alias#804
anishfish2 wants to merge 3 commits intogit-ai-project:mainfrom
anishfish2:feat/firebender-agent-support

Conversation

@anishfish2
Copy link
Copy Markdown

@anishfish2 anishfish2 commented Mar 26, 2026

Summary

  • add firebender as a first-class git-ai checkpoint preset alias backed by the existing ai_tab payload schema (before_edit / after_edit)
  • preserve firebender as the tool label in agent metadata so downstream attribution reflects the actual agent
  • update CLI help text and test preset recognition to include firebender
  • add integration coverage validating Firebender alias attribution end-to-end

Test plan

  • Run integration flow with checkpoint firebender --hook-input ... for before_edit and after_edit
  • Commit and verify new lines are attributed as AI in blame assertions
  • Confirm existing ai_tab behavior remains unchanged

Open with Devin

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@anishfish2 anishfish2 force-pushed the feat/firebender-agent-support branch from 7a30340 to 6f88301 Compare March 26, 2026 01:13
- add dedicated Firebender checkpoint preset with before_edit/after_edit payload handling\n- classify Firebender after_edit checkpoints as ai_agent\n- wire firebender as a first-class checkpoint preset in CLI dispatch and help text\n- register firebender in test preset recognition\n- add Firebender badge asset and README supported-agent listing\n- ensure Firebender session IDs use firebender- prefix
@anishfish2 anishfish2 force-pushed the feat/firebender-agent-support branch from 6f88301 to 102128e Compare March 26, 2026 01:16
@svarlamov
Copy link
Copy Markdown
Member

Thanks for the contribution @anishfish2! Quick question, can you point me in the right direction for the docs on Firebender hooks? It looks like the hook names in the mdm hooks setup are the same as Cursor's hooks, but they are actually the old cursor hooks format. Any instructions re how to test, etc. would be helpful. Thanks

@kevo1ution
Copy link
Copy Markdown

hey @svarlamov these are the firebender docs on hooks https://docs.firebender.com/multi-agent/hooks.

for testing, you can download the plugin from https://plugins.jetbrains.com/plugin/25224-firebender/ on intellij. if you send an email to kevin@firebender.com, I can temporarily white list your account

@svarlamov
Copy link
Copy Markdown
Member

Hey @kevo1ution that sounds great. I think this PR may have been authored just before we cut our Cursor agent preset over to using the preToolUse/postToolUse hooks. That's how all the rest of our agent impls work as well, but Cursor was a one-off as they didn't support the pre/post tool use hooks until somewhat recently. Do you have bandwidth to update this PR to that new flow? Let me know if there's anything I can help with/explain there.

Excited to add Firebender support to Git AI

@kevo1ution
Copy link
Copy Markdown

Yep I can take a look to scope out the work @svarlamov , thanks for the feedback!

@kevo1ution
Copy link
Copy Markdown

Superseded by draft PR #917 from a maintained branch because the original head branch is stale. Continuing follow-up work there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants