feat: add firebender checkpoint support#917
Open
kevo1ution wants to merge 8 commits intogit-ai-project:mainfrom
Open
feat: add firebender checkpoint support#917kevo1ution wants to merge 8 commits intogit-ai-project:mainfrom
kevo1ution wants to merge 8 commits intogit-ai-project:mainfrom
Conversation
Support Firebender hook payloads and installer config so Firebender edits can be attributed correctly in git-ai and tested independently of the stale upstream PR. 🤖 Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
3 tasks
Use Firebender's preToolUse/postToolUse flow so the integration matches the current hook model maintainers requested, while keeping legacy hook payloads as safe no-ops for existing installs. 🤖 Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
🤖 Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
|
|
🤖 Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
Ensure Firebender checkpoints capture edited files from apply_patch-style payloads and move preset coverage into the integration suite to match the repository's testing conventions. 🤖 Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
Explain that Firebender emits multiple real hook payload forms so the path extraction logic reads as intentional compatibility rather than speculative complexity. 🤖 Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
Normalize absolute Firebender hook paths relative to the repo so checkpoint filtering captures real edits, and cover the regression with integration tests. Also allow blank Firebender models to fall back to unknown to match observed hook behavior. 🤖 Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
🤖 Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
Author
|
@svarlamov this PR should address your comment at #804 (comment) I also tested and verified this worked locally against the coding agent. In order to test, you can install intellij and the plugin at https://plugins.jetbrains.com/plugin/25224-firebender Let me know if you see any issues here. Thanks! |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beforeSubmitPrompt/afterFileEditwiring topreToolUse/postToolUseWrite,Edit,Delete,RenameSymbol,DeleteSymbol) using the current tool hook payload shapeTest plan
cargo fmtcargo test firebendercargo checkCloses #804
🤖 Generated with Firebender