Conversation
Previously we called 'export' to append main() into the test file. Dart Test package 1.29.0 now disallows this pattern. TIL that the test package is released separate from the main Dart binary! Fixes #195
Goodwine
commented
Mar 25, 2026
|
|
||
| void main() { | ||
| shared_browser_tests.main(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
As I haven't been working with Dart, I'm not sure if this is better over void main() => shared_browser_tests.main() 🤔
I kinda like it better like this instead of an arrow function, but maybe that's my Go-brain talking lol
nex3
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we called 'export' to append main() into the test file. Dart Test package 1.29.0 now disallows this pattern. TIL that the test package is released separate from the main Dart binary!
Fixes #195