Skip to content

Fix browser tests by importing the shared tests instead of exporting #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goodwine merged 1 commit into from
Mar 26, 2026
Merged

Fix browser tests by importing the shared tests instead of exporting #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser_library_test/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion browser_library_test/test/esbuild_import_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,8 @@ library;

import 'package:test/test.dart';

export 'browser_test_shared.dart';
import 'browser_test_shared.dart' as shared_browser_tests;

void main() {
shared_browser_tests.main();
}
6 changes: 5 additions & 1 deletion browser_library_test/test/esbuild_require_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,8 @@ library;

import 'package:test/test.dart';

export 'browser_test_shared.dart';
import 'browser_test_shared.dart' as shared_browser_tests;

void main() {
shared_browser_tests.main();
}
Copy link
Copy Markdown
Contributor Author

@Goodwine Goodwine Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I haven't been working with Dart, I'm not sure if this is better over void main() => shared_browser_tests.main() 🤔

I kinda like it better like this instead of an arrow function, but maybe that's my Go-brain talking lol

6 changes: 5 additions & 1 deletion browser_library_test/test/jspm_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,8 @@ library;

import 'package:test/test.dart';

export 'browser_test_shared.dart';
import 'browser_test_shared.dart' as shared_browser_tests;

void main() {
shared_browser_tests.main();
}
6 changes: 5 additions & 1 deletion browser_library_test/test/rollup_import_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,8 @@ library;

import 'package:test/test.dart';

export 'browser_test_shared.dart';
import 'browser_test_shared.dart' as shared_browser_tests;

void main() {
shared_browser_tests.main();
}
6 changes: 5 additions & 1 deletion browser_library_test/test/rollup_require_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,8 @@ library;

import 'package:test/test.dart';

export 'browser_test_shared.dart';
import 'browser_test_shared.dart' as shared_browser_tests;

void main() {
shared_browser_tests.main();
}
6 changes: 5 additions & 1 deletion browser_library_test/test/vite_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,8 @@ library;

import 'package:test/test.dart';

export 'browser_test_shared.dart';
import 'browser_test_shared.dart' as shared_browser_tests;

void main() {
shared_browser_tests.main();
}
6 changes: 5 additions & 1 deletion browser_library_test/test/webpack_import_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,8 @@ library;

import 'package:test/test.dart';

export 'browser_test_shared.dart';
import 'browser_test_shared.dart' as shared_browser_tests;

void main() {
shared_browser_tests.main();
}
6 changes: 5 additions & 1 deletion browser_library_test/test/webpack_require_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,8 @@ library;

import 'package:test/test.dart';

export 'browser_test_shared.dart';
import 'browser_test_shared.dart' as shared_browser_tests;

void main() {
shared_browser_tests.main();
}
Loading