Skip to content

chore: Remove unncessary use of new and &SomeStruct{}#4106

Open
gmlewis wants to merge 1 commit intogoogle:masterfrom
gmlewis:i4103-new-some-struct
Open

chore: Remove unncessary use of new and &SomeStruct{}#4106
gmlewis wants to merge 1 commit intogoogle:masterfrom
gmlewis:i4103-new-some-struct

Conversation

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Mar 17, 2026

Fixes: #4103.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 17, 2026
@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 17, 2026

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 99.56616% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.68%. Comparing base (247ddc3) to head (ff69733).

Files with missing lines Patch % Lines
github/repos_forks.go 66.66% 1 Missing and 1 partial ⚠️
github/security_advisories.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4106      +/-   ##
==========================================
- Coverage   93.68%   93.68%   -0.01%     
==========================================
  Files         211      211              
  Lines       19511    19510       -1     
==========================================
- Hits        18279    18278       -1     
  Misses       1034     1034              
  Partials      198      198              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we implement a linter to automatically detect that? I don’t think it would be hard to do.


nit: typo in the title: unncessary -> unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up unnecessary use of new and &SomeStruct{}

2 participants