Skip to content

chore: Remove unnecessary use of new and &SomeStruct{} #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmlewis wants to merge 1 commit into
base: master
Choose a base branch
from
+1,355 −1,327
Open

chore: Remove unnecessary use of new and &SomeStruct{} #4106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions github/actions_artifacts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ func (s *ActionsService) ListArtifacts(ctx context.Context, owner, repo string,
return nil, nil, err
}

artifactList := new(ArtifactList)
resp, err := s.client.Do(ctx, req, artifactList)
var artifactList *ArtifactList
resp, err := s.client.Do(ctx, req, &artifactList)
if err != nil {
return nil, resp, err
}
Expand All @@ -122,8 +122,8 @@ func (s *ActionsService) ListWorkflowRunArtifacts(ctx context.Context, owner, re
return nil, nil, err
}

artifactList := new(ArtifactList)
resp, err := s.client.Do(ctx, req, artifactList)
var artifactList *ArtifactList
resp, err := s.client.Do(ctx, req, &artifactList)
if err != nil {
return nil, resp, err
}
Expand All @@ -144,8 +144,8 @@ func (s *ActionsService) GetArtifact(ctx context.Context, owner, repo string, ar
return nil, nil, err
}

artifact := new(Artifact)
resp, err := s.client.Do(ctx, req, artifact)
var artifact *Artifact
resp, err := s.client.Do(ctx, req, &artifact)
if err != nil {
return nil, resp, err
}
Expand Down
20 changes: 10 additions & 10 deletions github/actions_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ func (s *ActionsService) ListCaches(ctx context.Context, owner, repo string, opt
return nil, nil, err
}

actionCacheList := new(ActionsCacheList)
resp, err := s.client.Do(ctx, req, actionCacheList)
var actionCacheList *ActionsCacheList
resp, err := s.client.Do(ctx, req, &actionCacheList)
if err != nil {
return nil, resp, err
}
Expand Down Expand Up @@ -160,8 +160,8 @@ func (s *ActionsService) GetCacheUsageForRepo(ctx context.Context, owner, repo s
return nil, nil, err
}

cacheUsage := new(ActionsCacheUsage)
res, err := s.client.Do(ctx, req, cacheUsage)
var cacheUsage *ActionsCacheUsage
res, err := s.client.Do(ctx, req, &cacheUsage)
if err != nil {
return nil, res, err
}
Expand Down Expand Up @@ -190,8 +190,8 @@ func (s *ActionsService) ListCacheUsageByRepoForOrg(ctx context.Context, org str
return nil, nil, err
}

cacheUsage := new(ActionsCacheUsageList)
res, err := s.client.Do(ctx, req, cacheUsage)
var cacheUsage *ActionsCacheUsageList
res, err := s.client.Do(ctx, req, &cacheUsage)
if err != nil {
return nil, res, err
}
Expand All @@ -215,8 +215,8 @@ func (s *ActionsService) GetTotalCacheUsageForOrg(ctx context.Context, org strin
return nil, nil, err
}

cacheUsage := new(TotalCacheUsage)
res, err := s.client.Do(ctx, req, cacheUsage)
var cacheUsage *TotalCacheUsage
res, err := s.client.Do(ctx, req, &cacheUsage)
if err != nil {
return nil, res, err
}
Expand All @@ -239,8 +239,8 @@ func (s *ActionsService) GetTotalCacheUsageForEnterprise(ctx context.Context, en
return nil, nil, err
}

cacheUsage := new(TotalCacheUsage)
res, err := s.client.Do(ctx, req, cacheUsage)
var cacheUsage *TotalCacheUsage
res, err := s.client.Do(ctx, req, &cacheUsage)
if err != nil {
return nil, res, err
}
Expand Down
38 changes: 19 additions & 19 deletions github/actions_hosted_runners.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (s *ActionsService) ListHostedRunners(ctx context.Context, org string, opts
return nil, nil, err
}

runners := &HostedRunners{}
var runners *HostedRunners
resp, err := s.client.Do(ctx, req, &runners)
if err != nil {
return nil, resp, err
Expand Down Expand Up @@ -151,8 +151,8 @@ func (s *ActionsService) CreateHostedRunner(ctx context.Context, org string, req
return nil, nil, err
}

hostedRunner := new(HostedRunner)
resp, err := s.client.Do(ctx, req, hostedRunner)
var hostedRunner *HostedRunner
resp, err := s.client.Do(ctx, req, &hostedRunner)
if err != nil {
return nil, resp, err
}
Expand Down Expand Up @@ -187,8 +187,8 @@ func (s *ActionsService) GetHostedRunnerGitHubOwnedImages(ctx context.Context, o
return nil, nil, err
}

hostedRunnerImages := new(HostedRunnerImages)
resp, err := s.client.Do(ctx, req, hostedRunnerImages)
var hostedRunnerImages *HostedRunnerImages
resp, err := s.client.Do(ctx, req, &hostedRunnerImages)
if err != nil {
return nil, resp, err
}
Expand All @@ -208,8 +208,8 @@ func (s *ActionsService) GetHostedRunnerPartnerImages(ctx context.Context, org s
return nil, nil, err
}

hostedRunnerImages := new(HostedRunnerImages)
resp, err := s.client.Do(ctx, req, hostedRunnerImages)
var hostedRunnerImages *HostedRunnerImages
resp, err := s.client.Do(ctx, req, &hostedRunnerImages)
if err != nil {
return nil, resp, err
}
Expand Down Expand Up @@ -240,8 +240,8 @@ func (s *ActionsService) GetHostedRunnerLimits(ctx context.Context, org string)
return nil, nil, err
}

publicIPLimits := new(HostedRunnerPublicIPLimits)
resp, err := s.client.Do(ctx, req, publicIPLimits)
var publicIPLimits *HostedRunnerPublicIPLimits
resp, err := s.client.Do(ctx, req, &publicIPLimits)
if err != nil {
return nil, resp, err
}
Expand All @@ -267,8 +267,8 @@ func (s *ActionsService) GetHostedRunnerMachineSpecs(ctx context.Context, org st
return nil, nil, err
}

machineSpecs := new(HostedRunnerMachineSpecs)
resp, err := s.client.Do(ctx, req, machineSpecs)
var machineSpecs *HostedRunnerMachineSpecs
resp, err := s.client.Do(ctx, req, &machineSpecs)
if err != nil {
return nil, resp, err
}
Expand All @@ -294,8 +294,8 @@ func (s *ActionsService) GetHostedRunnerPlatforms(ctx context.Context, org strin
return nil, nil, err
}

platforms := new(HostedRunnerPlatforms)
resp, err := s.client.Do(ctx, req, platforms)
var platforms *HostedRunnerPlatforms
resp, err := s.client.Do(ctx, req, &platforms)
if err != nil {
return nil, resp, err
}
Expand All @@ -315,8 +315,8 @@ func (s *ActionsService) GetHostedRunner(ctx context.Context, org string, runner
return nil, nil, err
}

hostedRunner := new(HostedRunner)
resp, err := s.client.Do(ctx, req, hostedRunner)
var hostedRunner *HostedRunner
resp, err := s.client.Do(ctx, req, &hostedRunner)
if err != nil {
return nil, resp, err
}
Expand All @@ -336,8 +336,8 @@ func (s *ActionsService) UpdateHostedRunner(ctx context.Context, org string, run
return nil, nil, err
}

hostedRunner := new(HostedRunner)
resp, err := s.client.Do(ctx, req, hostedRunner)
var hostedRunner *HostedRunner
resp, err := s.client.Do(ctx, req, &hostedRunner)
if err != nil {
return nil, resp, err
}
Expand All @@ -357,8 +357,8 @@ func (s *ActionsService) DeleteHostedRunner(ctx context.Context, org string, run
return nil, nil, err
}

hostedRunner := new(HostedRunner)
resp, err := s.client.Do(ctx, req, hostedRunner)
var hostedRunner *HostedRunner
resp, err := s.client.Do(ctx, req, &hostedRunner)
if err != nil {
return nil, resp, err
}
Expand Down
4 changes: 2 additions & 2 deletions github/actions_oidc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ func (s *ActionsService) getOIDCSubjectClaimCustomTemplate(ctx context.Context,
return nil, nil, err
}

tmpl := new(OIDCSubjectClaimCustomTemplate)
resp, err := s.client.Do(ctx, req, tmpl)
var tmpl *OIDCSubjectClaimCustomTemplate
resp, err := s.client.Do(ctx, req, &tmpl)
if err != nil {
return nil, resp, err
}
Expand Down
44 changes: 22 additions & 22 deletions github/actions_permissions_enterprise.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ func (s *ActionsService) GetActionsPermissionsInEnterprise(ctx context.Context,
return nil, nil, err
}

permissions := new(ActionsPermissionsEnterprise)
resp, err := s.client.Do(ctx, req, permissions)
var permissions *ActionsPermissionsEnterprise
resp, err := s.client.Do(ctx, req, &permissions)
if err != nil {
return nil, resp, err
}
Expand All @@ -80,8 +80,8 @@ func (s *ActionsService) UpdateActionsPermissionsInEnterprise(ctx context.Contex
return nil, nil, err
}

p := new(ActionsPermissionsEnterprise)
resp, err := s.client.Do(ctx, req, p)
var p *ActionsPermissionsEnterprise
resp, err := s.client.Do(ctx, req, &p)
if err != nil {
return nil, resp, err
}
Expand All @@ -106,8 +106,8 @@ func (s *ActionsService) ListEnabledOrgsInEnterprise(ctx context.Context, owner
return nil, nil, err
}

orgs := &ActionsEnabledOnEnterpriseRepos{}
resp, err := s.client.Do(ctx, req, orgs)
var orgs *ActionsEnabledOnEnterpriseRepos
resp, err := s.client.Do(ctx, req, &orgs)
if err != nil {
return nil, resp, err
}
Expand Down Expand Up @@ -193,8 +193,8 @@ func (s *ActionsService) GetActionsAllowedInEnterprise(ctx context.Context, ente
return nil, nil, err
}

actionsAllowed := new(ActionsAllowed)
resp, err := s.client.Do(ctx, req, actionsAllowed)
var actionsAllowed *ActionsAllowed
resp, err := s.client.Do(ctx, req, &actionsAllowed)
if err != nil {
return nil, resp, err
}
Expand All @@ -214,8 +214,8 @@ func (s *ActionsService) UpdateActionsAllowedInEnterprise(ctx context.Context, e
return nil, nil, err
}

p := new(ActionsAllowed)
resp, err := s.client.Do(ctx, req, p)
var p *ActionsAllowed
resp, err := s.client.Do(ctx, req, &p)
if err != nil {
return nil, resp, err
}
Expand All @@ -236,8 +236,8 @@ func (s *ActionsService) GetDefaultWorkflowPermissionsInEnterprise(ctx context.C
return nil, nil, err
}

permissions := new(DefaultWorkflowPermissionEnterprise)
resp, err := s.client.Do(ctx, req, permissions)
var permissions *DefaultWorkflowPermissionEnterprise
resp, err := s.client.Do(ctx, req, &permissions)
if err != nil {
return nil, resp, err
}
Expand All @@ -257,8 +257,8 @@ func (s *ActionsService) UpdateDefaultWorkflowPermissionsInEnterprise(ctx contex
return nil, nil, err
}

p := new(DefaultWorkflowPermissionEnterprise)
resp, err := s.client.Do(ctx, req, p)
var p *DefaultWorkflowPermissionEnterprise
resp, err := s.client.Do(ctx, req, &p)
if err != nil {
return nil, resp, err
}
Expand All @@ -279,8 +279,8 @@ func (s *ActionsService) GetArtifactAndLogRetentionPeriodInEnterprise(ctx contex
return nil, nil, err
}

arp := new(ArtifactPeriod)
resp, err := s.client.Do(ctx, req, arp)
var arp *ArtifactPeriod
resp, err := s.client.Do(ctx, req, &arp)
if err != nil {
return nil, resp, err
}
Expand Down Expand Up @@ -315,8 +315,8 @@ func (s *ActionsService) GetSelfHostedRunnerPermissionsInEnterprise(ctx context.
return nil, nil, err
}

permissions := new(SelfHostRunnerPermissionsEnterprise)
resp, err := s.client.Do(ctx, req, permissions)
var permissions *SelfHostRunnerPermissionsEnterprise
resp, err := s.client.Do(ctx, req, &permissions)
if err != nil {
return nil, resp, err
}
Expand Down Expand Up @@ -352,8 +352,8 @@ func (s *ActionsService) GetPrivateRepoForkPRWorkflowSettingsInEnterprise(ctx co
return nil, nil, err
}

permissions := new(WorkflowsPermissions)
resp, err := s.client.Do(ctx, req, permissions)
var permissions *WorkflowsPermissions
resp, err := s.client.Do(ctx, req, &permissions)
if err != nil {
return nil, resp, err
}
Expand Down Expand Up @@ -389,8 +389,8 @@ func (s *ActionsService) GetEnterpriseForkPRContributorApprovalPermissions(ctx c
return nil, nil, err
}

policy := new(ContributorApprovalPermissions)
resp, err := s.client.Do(ctx, req, policy)
var policy *ContributorApprovalPermissions
resp, err := s.client.Do(ctx, req, &policy)
if err != nil {
return nil, resp, err
}
Expand Down
Loading
Loading