Fix missing transitive deps from ffmpeg pkgconfig#172
Open
KKhanhH wants to merge 1 commit intoh4tr3d:masterfrom
Open
Fix missing transitive deps from ffmpeg pkgconfig#172KKhanhH wants to merge 1 commit intoh4tr3d:masterfrom
KKhanhH wants to merge 1 commit intoh4tr3d:masterfrom
Conversation
KKhanhH
force-pushed
the
transitive-ffmpeg-deps
branch
from
39d0fc1 to
15f3553
Compare
KKhanhH
force-pushed
the
transitive-ffmpeg-deps
branch
from
15f3553 to
29c098f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FFmpeg::FFmpeg library target created by the FindFFmpeg module doesn't link with the FFmpeg::${_lowerComponent}, only with the raw top level libraries provided to FFMPEG_LIBRARIES, which would exclude transitive deps pkgconfig might provide. Also, there's a small minor bug with the separator provided to the INTERFACE_LINK_LIBRARIES of the component target.