Skip to content

Fix missing transitive deps from ffmpeg pkgconfig #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KKhanhH wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing transitive deps from ffmpeg pkgconfig #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmake/FindFFmpeg.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ if (TRUE)
message(STATUS "Libs: ${${_component}_LIBRARIES} | ${PC_${_component}_LIBRARIES}")

# message(STATUS "Required component ${_component} present.")
set(FFMPEG_LIBRARIES ${FFMPEG_LIBRARIES} ${${_component}_LIBRARIES})
set(FFMPEG_LIBRARIES ${FFMPEG_LIBRARIES} ${${_component}_LIBRARIES} ${PC_${_component}_LINK_LIBRARIES})
set(FFMPEG_DEFINITIONS ${FFMPEG_DEFINITIONS} ${${_component}_DEFINITIONS})

list(APPEND FFMPEG_INCLUDE_DIRS ${${_component}_INCLUDE_DIRS})
Expand All @@ -246,9 +246,10 @@ if (TRUE)
set_target_properties(FFmpeg::${_lowerComponent} PROPERTIES
INTERFACE_COMPILE_OPTIONS "${${_component}_DEFINITIONS}"
INTERFACE_INCLUDE_DIRECTORIES ${${_component}_INCLUDE_DIRS}
INTERFACE_LINK_LIBRARIES "${${_component}_LIBRARY} ${${_component}_LIBRARIES} ${PC_${_component}_LIBRARIES}"
INTERFACE_LINK_LIBRARIES "${${_component}_LIBRARY};${${_component}_LIBRARIES};${PC_${_component}_LINK_LIBRARIES}"
IMPORTED_LINK_INTERFACE_MULTIPLICITY 3)
endif()
list(APPEND _FFMPEG_COMPONENT_TARGETS FFmpeg::${_lowerComponent})
else()
# message(STATUS "Required component ${_component} missing.")
endif()
Expand All @@ -271,7 +272,7 @@ if (NOT TARGET FFmpeg::FFmpeg)
set_target_properties(FFmpeg PROPERTIES
INTERFACE_COMPILE_OPTIONS "${FFMPEG_DEFINITIONS}"
INTERFACE_INCLUDE_DIRECTORIES "${FFMPEG_INCLUDE_DIRS}"
INTERFACE_LINK_LIBRARIES "${FFMPEG_LIBRARIES}")
INTERFACE_LINK_LIBRARIES "${_FFMPEG_COMPONENT_TARGETS}")
add_library(FFmpeg::FFmpeg ALIAS FFmpeg)
endif()

Expand Down
Loading