Skip to content

Fix dashboard account pool divider #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yvette-carlisle merged 1 commit into from
Jun 5, 2026
Merged

Fix dashboard account pool divider #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/decodex/src/orchestrator/operator_dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2125,7 +2125,7 @@
cursor: pointer;
}

.account-pool-list > .account-row:last-child {
.account-pool-list > .account-row.is-last-account {
border-bottom: 0;
}

Expand Down Expand Up @@ -7185,7 +7185,7 @@ <h2 id="recent-title">Run History</h2>
`;
}

function renderCodexAccountPoolRow(account, snapshot) {
function renderCodexAccountPoolRow(account, snapshot, isLastAccount = false) {
const weight = codexAccountCapacityLabel(account);
const statusTone = codexAccountStatusTone(account);
const toneClass = statusTone ? ` is-${statusTone}` : "";
Expand All @@ -7207,12 +7207,13 @@ <h2 id="recent-title">Run History</h2>
const profileExpanded = hasProfileDetails && codexAccountProfileExpanded(account);
const profileOpenClass = profileExpanded ? " is-profile-open" : "";
const profileToggleableClass = hasProfileDetails ? " is-profile-toggleable" : "";
const lastAccountClass = isLastAccount ? " is-last-account" : "";
const profileRowToggleAttribute = hasProfileDetails
? ` data-account-profile-row-toggle="${escapeHtml(profileKey)}"`
: "";

return `
<div class="account-row${selectedClass}${fixedClass}${armedClass}${toneClass}${profileOpenClass}${profileToggleableClass}" data-render-key="account-row:${escapeHtml(profileKey)}"${profileRowToggleAttribute}>
<div class="account-row${selectedClass}${fixedClass}${armedClass}${toneClass}${profileOpenClass}${profileToggleableClass}${lastAccountClass}" data-render-key="account-row:${escapeHtml(profileKey)}"${profileRowToggleAttribute}>
<div class="account-row-id${identityClass}">
${renderCodexAccountNameControl(account, snapshot)}
${renderCodexAccountRandomNameButton(account)}
Expand Down Expand Up @@ -7446,7 +7447,7 @@ <h2 id="recent-title">Run History</h2>
<div class="account-pool-guide">
${ACCOUNT_POOL_SORT_COLUMNS.map(renderCodexAccountPoolGuideCell).join("")}
</div>
${accounts.map((account) => renderCodexAccountPoolRow(account, snapshot)).join("")}
${accounts.map((account, index) => renderCodexAccountPoolRow(account, snapshot, index === accounts.length - 1)).join("")}
</div>
`;
}
Expand Down
11 changes: 9 additions & 2 deletions apps/decodex/src/orchestrator/tests/operator/status/dashboard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,9 @@ fn operator_dashboard_renders_account_usage_controls() {
assert!(response.contains("function codexAccountPoolMergeRank(account)"));
assert!(response.contains("function renderCodexAccountPool(accounts, snapshot)"));
assert!(!response.contains("function renderCodexAccountPoolHeader(accounts)"));
assert!(response.contains("function renderCodexAccountPoolRow(account, snapshot)"));
assert!(response.contains(
"function renderCodexAccountPoolRow(account, snapshot, isLastAccount = false)"
));
assert!(response.contains("function renderCodexAccountNameControl(account, snapshot)"));
assert!(!response.contains("ACCOUNT_SELECTION_CONFIRMATION_MS"));
assert!(!response.contains("accountSelectionConfirmationTimer"));
Expand Down Expand Up @@ -918,7 +920,12 @@ fn operator_dashboard_accounts_keeps_window_status_and_credit_copy_compact() {
assert!(response.contains("min-height: 42px;"));
assert!(response.contains("padding: var(--space-account-row-y) 28px var(--space-account-row-y) var(--space-row-indent);"));
assert!(response.contains("border-bottom: 1px solid var(--line);"));
assert!(response.contains(".account-pool-list > .account-row:last-child"));
assert!(response.contains(".account-pool-list > .account-row.is-last-account"));
assert!(response.contains("const lastAccountClass = isLastAccount ? \" is-last-account\" : \"\";"));
assert!(response.contains(
"accounts.map((account, index) => renderCodexAccountPoolRow(account, snapshot, index === accounts.length - 1))"
));
assert!(!response.contains(".account-pool-list > .account-row:last-child"));
assert!(response.contains("account-row-credit"));
assert!(response.contains(".account-row-credit {\n\t\t\t\tgrid-area: credit;"));
assert!(response.contains(".account-row-credit {\n\t\t\t\tgrid-area: credit;\n\t\t\t\tjustify-self: center;"));
Expand Down