add additional toolchain options #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cxxopts`: flags used only for compiling C++ targets `conlyopts`: flags used only for compiling C targets `dbg_compile_flags`: flags used when compiling in `dbg` mode `opt_compile_flags`: flags used when compiling in `opt` mode `opt_link_flags`: flags used when linking in `opt` mode
oliverlee
force-pushed
the
additional-toolchain-opts
branch
from
bbc5b9b to
aa19a5c
Compare
Contributor
Author
|
I'm not sure why tests started failing with: after adding additional options where the defaults don't change anything. I changed |
Owner
|
Hey @oliverlee, sorry I have been heads down on @diodeinc this week, will review soon |
Contributor
Author
|
No worries and thanks for the notice. |
Owner
|
This looks good to me, should we merge @oliverlee? |
Contributor
Author
|
I think this PR should be okay. I've been using it in another project without issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cxxopts: flags used only for compiling C++ targetsconlyopts: flags used only for compiling C targetsdbg_compile_flags: flags used when compiling indbgmodeopt_compile_flags: flags used when compiling inoptmodeopt_link_flags: flags used when linking inoptmode